Skip to content

fix(corpus): make standalone Corpus test self-contained - #45

Open
Nelsonifenna wants to merge 1 commit into
ever-guild:mainfrom
Nelsonifenna:fix/pr-018-corpus-self-contained
Open

fix(corpus): make standalone Corpus test self-contained#45
Nelsonifenna wants to merge 1 commit into
ever-guild:mainfrom
Nelsonifenna:fix/pr-018-corpus-self-contained

Conversation

@Nelsonifenna

Copy link
Copy Markdown

Summary

This PR makes the Corpus test suite independently runnable from a clean checkout.

Problem

packages/corpus/package.json previously built only the schema package before running Corpus tests. However, the Corpus integration tests depend transitively on the built receipt and metadata packages.

As a result, the standalone command:

pnpm --filter @ever-guild/proof-runner-corpus test

could fail on a clean checkout, while the root test suite could hide the problem because other workspace pretest/build steps had already produced the required artifacts.

Solution

  • Updated the Corpus pretest script to build schema, receipt, and metadata before running the tests.
  • Added a CI regression guard that runs the standalone Corpus test immediately after pnpm install --frozen-lockfile, before other workspace builds can mask the dependency.

Testing

Verified that the standalone Corpus test passes from a clean dist/ state:

  • 5/5 test files
  • 37/37 tests

Also verified the relevant lint, typecheck, build, and root test commands without introducing regressions.

Issue

Closes #43

@ilyar

ilyar commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 86ab06375e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ever-guild-ops ever-guild-ops left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Scope reviewed: .github/workflows/ci.yml and packages/corpus/package.json against open head 86ab06375e... (merged against main).

Observed behavior and checks:

  • Confirmed reported issue is fixed: on base 13b061d... pnpm --filter @ever-guild/proof-runner-corpus test fails with unresolved @ever-guild/proof-runner-metadata.
  • On PR head, pnpm --filter @ever-guild/proof-runner-corpus test passes (5 files, 37 tests).
  • pnpm test is currently blocked by environment (missing Playwright Chromium headless shell at runtime); this is an external test infra limitation and not caused by this change.
  • In the same snapshot, pnpm typecheck, pnpm lint, and pnpm build all passed.

Given no PR-introduced correctness, security, or acceptance blockers remain, this is approvable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PR-018] Make standalone Corpus tests self-contained

3 participants