fix(corpus): make standalone Corpus test self-contained - #45
Open
Nelsonifenna wants to merge 1 commit into
Open
Conversation
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ever-guild-ops
approved these changes
Aug 9, 2026
ever-guild-ops
left a comment
There was a problem hiding this comment.
No blocking issues found.
Scope reviewed: .github/workflows/ci.yml and packages/corpus/package.json against open head 86ab06375e... (merged against main).
Observed behavior and checks:
- Confirmed reported issue is fixed: on base
13b061d...pnpm --filter @ever-guild/proof-runner-corpus testfails with unresolved@ever-guild/proof-runner-metadata. - On PR head,
pnpm --filter @ever-guild/proof-runner-corpus testpasses (5 files, 37 tests). pnpm testis currently blocked by environment (missing Playwright Chromium headless shell at runtime); this is an external test infra limitation and not caused by this change.- In the same snapshot,
pnpm typecheck,pnpm lint, andpnpm buildall passed.
Given no PR-introduced correctness, security, or acceptance blockers remain, this is approvable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the Corpus test suite independently runnable from a clean checkout.
Problem
packages/corpus/package.jsonpreviously built only the schema package before running Corpus tests. However, the Corpus integration tests depend transitively on the builtreceiptandmetadatapackages.As a result, the standalone command:
pnpm --filter @ever-guild/proof-runner-corpus testcould fail on a clean checkout, while the root test suite could hide the problem because other workspace pretest/build steps had already produced the required artifacts.
Solution
pretestscript to buildschema,receipt, andmetadatabefore running the tests.pnpm install --frozen-lockfile, before other workspace builds can mask the dependency.Testing
Verified that the standalone Corpus test passes from a clean
dist/state:Also verified the relevant lint, typecheck, build, and root test commands without introducing regressions.
Issue
Closes #43