Skip to content

fix: allow additional properties in JSONLanguageOptions - #271

Open
lumirlumir wants to merge 1 commit into
mainfrom
fix/allow-additional-properties-in-jsonlanguageoptions
Open

fix: allow additional properties in JSONLanguageOptions#271
lumirlumir wants to merge 1 commit into
mainfrom
fix/allow-additional-properties-in-jsonlanguageoptions

Conversation

@lumirlumir

@lumirlumir lumirlumir commented Aug 17, 2026

Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

While eslint/eslint#19615 (comment) determined that XXXLanguageOptions can have additional properties, and MarkdownLanguageOptions already extends the LanguageOptions type from @eslint/core, the corresponding JSONLanguageOptions does not allow additional properties.

What changes did you make? (Give an overview)

So, I’ve updated JSONLanguageOptions to extend LanguageOptions from @eslint/core and added type test cases to verify that it allows additional properties.

Just a note: JSONLanguageOptions was already being exported from the main entry point, so this PR doesn’t introduce a new feature and only includes a fix.

Related Issues

Is there anything you'd like reviewers to focus on?

I found it while working on eslint/markdown#706.

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Aug 17, 2026
@eslintbot eslintbot added this to Triage Aug 17, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Aug 17, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Aug 17, 2026
@lumirlumir
lumirlumir marked this pull request as ready for review August 21, 2026 16:06
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage Aug 21, 2026
@lumirlumir
lumirlumir requested a review from a team August 25, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants