fix: allow additional properties in JSONLanguageOptions - #271
Open
lumirlumir wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
While eslint/eslint#19615 (comment) determined that
XXXLanguageOptionscan have additional properties, andMarkdownLanguageOptionsalready extends theLanguageOptionstype from@eslint/core, the correspondingJSONLanguageOptionsdoes not allow additional properties.What changes did you make? (Give an overview)
So, I’ve updated
JSONLanguageOptionsto extendLanguageOptionsfrom@eslint/coreand added type test cases to verify that it allows additional properties.Just a note:
JSONLanguageOptionswas already being exported from the main entry point, so this PR doesn’t introduce a new feature and only includes a fix.Related Issues
languageOptionseslint#19615 (comment)CSSLanguageOptionscss#538Is there anything you'd like reviewers to focus on?
I found it while working on eslint/markdown#706.