Repository navigation
fix: load state when the URL hash changes - #568
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughA ChangesHash-based state restoration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Share-link navigation and browser back/forward restore the editor state encoded in the current hash instead of leaving newer editor contents visible. No actionable merge risk remains. Pre-merge checks |
|
DMartens
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks. Leaving open for others to check as this was recently undrafted.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes a bug where opening a share link in a tab that already shows Code Explorer doesn't load the shared state, so the page keeps showing the previous state.
Steps to reproduce
const a = 1;and copy the page URL.const b = 2;.const b = 2;.What changes did you make? (Give an overview)
Reloaded the persisted state on
hashchangeusingpersist.rehydrate().Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit