Remove RPC source configuration from indexer skills#1370
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughDocumentation-only updates across three SKILL.md files remove and rename RPC-related sections in favor of HyperSync/WebSocket-focused guidance. Changes include deleting an RPC Configuration section, replacing RPC Tuning with WebSocket for Realtime Indexing content, and renaming headers/descriptions to drop explicit RPC references. ChangesSKILL.md Documentation Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Drop the dedicated RPC-as-a-data-source documentation from the managed indexer skill set, keeping the WebSocket realtime section: - indexer-performance: remove the RPC Tuning section (tuning params and `for` options); keep the WebSocket for Realtime Indexing section and drop RPC-tuning wording from the skill description - indexer-configuration: remove the RPC Configuration pointer section - indexer-troubleshooting: remove the RPC rate-limit/tuning error bullet, rename the section to HyperSync Errors, and drop RPC from the description Handler-level RPC usage (Effect API / viem in indexer-external-calls and indexer-traces), the ENVIO_ env-var examples, and the rpc_config deprecation note are left intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014aVfvTqexSNr2V4i4MaBEB
e9d48b7 to
f6d20ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dedicated RPC-as-a-data-source documentation from the managed indexer skill set (
packages/cli/templates/static/shared/.claude/skills/). RPC source configuration is no longer surfaced as guidance in the skills — except the WebSocket realtime section, kept by request.Removed
## RPC Tuningsection (tuning params,foroptions table); RPC-tuning wording dropped from the frontmatter description. TheWebSocket for Realtime Indexingsection is kept (promoted from###to##now that its parent section is gone).## RPC Configurationpointer section.RPC / HyperSync Errors→HyperSync Errors; dropped RPC from the frontmatter description.Intentionally left in place
These reference RPC but aren't RPC source-configuration docs:
## Environment Variablessections in indexer-configuration and indexer-troubleshooting — they teach the requiredENVIO_prefix and only use anrpc:URL as the example.rpc_configdeprecation note in indexer-configuration — a "do not use" warning.🤖 Generated with Claude Code
Summary by CodeRabbit