Skip to content

NXT-16299: ImageItem cleanup #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-stoian-lgp merged 4 commits into from
Jun 26, 2026
Merged

NXT-16299: ImageItem cleanup #388

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a677fa4
Added empty `selectionIcon`
ion-andrusciac-lgp Jun 25, 2026
078b9b1
Merge branch 'develop' of https://github.com/enactjs/limestone into f…
ion-andrusciac-lgp Jun 25, 2026
2557f1e
Small fix
ion-andrusciac-lgp Jun 25, 2026
327fa97
Reverted changes
ion-andrusciac-lgp Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ImageItem/ImageItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import PropTypes from 'prop-types';
import compose from 'ramda/src/compose';

import $L from '../internal/$L';
import {CheckboxBase} from '../Checkbox';
import Icon from '../Icon';
import Image from '../Image';
import AsyncRenderChildren from '../internal/AsyncRenderChildren';
Expand All @@ -33,9 +32,6 @@ import Skinnable from '../Skinnable';

import componentCss from './ImageItem.module.less';

const Checkbox = Skinnable(CheckboxBase);
Checkbox.displayName = 'Checkbox';

const
defaultPlaceholder =
'data:image/svg+xml;charset=utf-8;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC' +
Expand Down Expand Up @@ -289,7 +285,7 @@ const ImageItemBase = kind({
if (SelectionComponent) {
return <SelectionComponent />;
} else {
return <Icon className={css.selectionIcon} >checkmark</Icon>;
return <Icon className={css.selectionIcon}>checkmark</Icon>;
}
}
},
Expand Down
Loading