Fix NodeJS check for electron renderer#25
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same NODE_JS detection issue was fixed in js-sha256 (emn178/js-sha256#49) but not here. The check returns true in an Electron renderer started with
nodeIntegrationInWorker: true, becauseprocessexists in that context. Electron setsprocess.typeto"renderer"there, so this adds the matchingprocess.type != 'renderer'guard. With it the renderer takes the pure-JS path instead of trying to wrap Node'scrypto.The change is the same one-line guard already merged in js-sha256.
mocha tests/node-test.jsstill passes (8360 tests): under normal Nodeprocess.typeis undefined, soNODE_JSstays true and behavior there is unchanged.