Add horizontal scrolling to the Components tree - #2679
Open
pichfl wants to merge 7 commits into
Open
Conversation
pichfl
marked this pull request as draft
August 5, 2025 12:31
pichfl
force-pushed
the
pichfl/scroll-left
branch
from
August 6, 2025 13:05
8008995 to
45f144d
Compare
pichfl
marked this pull request as ready for review
August 6, 2025 13:06
mansona
approved these changes
Aug 18, 2025
mansona
left a comment
mansona
left a comment
Member
There was a problem hiding this comment.
very close, one very very very minor change. Happy to merge without fixing it tbh
pichfl
force-pushed
the
pichfl/scroll-left
branch
from
August 18, 2025 14:50
45f144d to
97062bf
Compare
pichfl
force-pushed
the
pichfl/scroll-left
branch
from
August 18, 2025 14:55
97062bf to
080acfc
Compare
mansona
requested changes
Aug 18, 2025
mansona
left a comment
mansona
left a comment
Member
There was a problem hiding this comment.
I tested the built package and it looks like we introduced a bug 😞 now when you have selected a component, as you hover over other components in the tree it will "jump" you back to the left-right scroll position of the selected component.
I was on a call with @pichfl when I discovered this and he saw the behaviour so I won't provide a video but I can if we need to 👍
Contributor
Author
|
I've updated my code. It does the job, but I'm not convinced of the usefulness of this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2614