skills: tell the whole story in the public skill, and fix what went stale - #100
Conversation
…tale The skill described the mechanics of the platform without the problem it solves, so a coding agent reading it could operate Ellipsis but not say why a team would adopt it. Adds the fleet-management problem, why cloud beats laptop, and the benefits that were missing: usage-based pricing, any model, structured output as a contract, and session observability. Code review had drifted furthest from the product. include_default_reviewers is gone, position now decides what a code_review.yaml governs, and enabled: false does the opposite of what the skill claimed. Also corrects 'agent session handoff', which was shown without its required --parent.
There was a problem hiding this comment.
Caution
Changes requested ❌ — 2 issues
Reviewed df96073 in 6 minutes, 33 seconds.
- Reviewed
1commit with397lines of code in1file - Ran
1review agent producing2comments where2were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by . You can tag
@ellipsis in this pull request.
| agent review 519 --full # re-review the whole PR, ignoring earlier reviews | ||
| agent review --no-post # print findings instead of posting to GitHub |
There was a problem hiding this comment.
The --no-post example lost its PR number when the working-tree paragraph was deleted, so it now demonstrates the local snapshot path instead of a PR review. Add the number.
This hunk deleted the bare agent review / --branch lines and the paragraph that explained the snapshot behavior, but kept agent review --no-post under the heading "Review pull requests on demand". With no PR number, buildCreateRequest takes the local branch (src/commands/review.ts:481-487): it creates a WIP commit and force-pushes it to ellipsis/review/<branch>, and hardcodes post: false so --no-post is a no-op there (see the comment at review.ts:478-480). A reader following this line to skip posting on PR 519 instead pushes a branch to their remote, and per this PR's own description that path sends fields the API dropped.
| agent review 519 --full # re-review the whole PR, ignoring earlier reviews | |
| agent review --no-post # print findings instead of posting to GitHub | |
| agent review 519 --full # re-review the whole PR, ignoring earlier reviews | |
| agent review 519 --no-post # print findings instead of posting to GitHub |
| Which pipeline runs is not a parameter. An explicit review resolves the same | ||
| pipeline by location that the webhook does, so the two entry points can never | ||
| disagree. A review with nothing new to cover returns a `skipped` review rather |
There was a problem hiding this comment.
"Which pipeline runs is not a parameter" contradicts the shipped CLI: agent review -c/--config <id> selects a pipeline, and the agent review default ladder is read only by explicit reviews.
src/commands/review.ts:65 registers -c, --config <id> ('run a saved agent config instead of the built-in reviewer'), and registerReviewDefaults (review.ts:275-278) documents a two-rung account/per-repo default whose comment states the opposite of this paragraph: 'Only explicit reviews read it: webhook reviews keep matching the pipelines' own pull_requests: filters.' Those endpoints are live in src/lib/api.ts:376-391. An agent using this skill will tell a user they cannot choose a pipeline for an explicit review, and has no way to explain a broken default rung, which fails explicit reviews closed (review.ts:349-352).
Summary
Rewrites
skills/ellipsis/SKILL.md. The skill explained the mechanics of the platform without the problem it solves, so a coding agent reading it could operate Ellipsis but not explain why a team would adopt it.Added the story:
Fixed what went stale. Code review had drifted furthest from the product:
include_default_reviewersno longer exists. A stage list replaces that stage wholesale.code_review.yaml, and its position decides scope: a repo root governs that repo, the.ellipsisrepo's copy governs the org. The oldagents/code_review.yamlconvention is now a config error.enabled: falsedoes the opposite of what the skill claimed: it marks the file inactive so the next rung applies, rather than suppressing review.descriptionstage, and that the gatekeeper is opt-in rather than built in.agent session handoff, shown without its required--parent, and softened "every command is singular" sincegithub,slack,budget, andusagehave no plural alias.Two bugs found while verifying, not fixed here
agent review initscaffolds an unusable file. It writes toagents/code_review.yaml(src/commands/review.ts:37), a path the backend now rejects viaassert_valid_for_location. Its template also still advertisesinclude_default_reviewersand "three reviewer lenses."agent reviewand--branchsend fields the API dropped.buildCreateRequestsendsbranch/sha/config_id/model/budget;CreateReviewRequestnow takes onlyowner,repo,pull_request_number,scope, andpost.This PR documents only the pull-request review path, so the skill is honest either way.
Test plan
parse_agent_config_yamlandparse_code_review_config_yamlvalidators (not a YAML-syntax check)--helpbun run typecheckclean; 426 tests passImportant
Rewrites
skills/ellipsis/SKILL.mdto explain the problem cloud agents solve, not just the mechanics of the platform.Added narrative:
Fixed stale code-review docs:
include_default_reviewersandagents/code_review.yamlpaths are now errors; pipeline file location (repo root or.ellipsisrepo root) determines scope, and location entirely replaces the organizational default.enabled: falsemarks file inactive (falls through to org file/built-in), not suppressing review.descriptionstage (default Haiku agent) and clarifiedfiltergatekeeper is opt-in, not built-in.reviewinherits default,descriptionandfilterinherit defaults unless declared.Updated CLI and config:
agent me,agent review --full, clarified--detach,--parentfor handoff.ELLIPSIS_API_BASE_URL.structured_outputas exit contract.This description was created by
for df96073. It will automatically update as commits are pushed.