feat(a11y): add access keys shortcuts#2768
Draft
userquin wants to merge 3 commits into
Draft
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
skip-contentattribute in MainContent SFC: SkipContentLink.vue SFCa11y.skip_navigationNOTE: to activate accesskeys you need to check your browser documentation, on my Windows laptop and using Chrome I can activate
Skip navigationusingAlt + 1. OnceAlt + 1pressed you can pressTab, should focus the next focusable element in the main content of the page, rn only settings pages withSkip navigationlinks included.EDIT: I need to change the styles in
SkipContent.tsandSkipCintentLink.vue, there is layout shift when activating the link and getting the focus the link inSkipContentLink.vue, @patak-dev maybe you can check it, I have a lot of work changing all pages./cc @danielroe @antfu for nuxt-a11y https://www.nomisweb.co.uk/home/accesskeys.asp#content-anchor