Repository navigation
build: bump @electron/lint-roller to ^4.0.0 - #2016
Conversation
Lockfile-only bump. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore npm/@electron/lint-roller@4.0.0 |
There was a problem hiding this comment.
Looks good, straightforward devDependency version bump.
Extended reasoning...
Overview
This PR only touches package.json (one line, bumping @ electron/lint-roller from ^3.1.3 to ^4.0.0) and the regenerated yarn.lock. No source files are changed.
Security risks
None. This is a devDependency-only change with no runtime/production code impact. The lockfile diff shows removal of the eslint-based transitive tree that came with lint-roller 3.x's removed lint-roller-markdown-standard bin, which is expected and reduces the dependency surface rather than expanding it.
Level of scrutiny
Low. Verified directly: the repo's only lint-roller usage is lint-roller-markdown-links via the lint:links script, which does not use either of the two flags dropped in 4.0.0 (--fetch-external-links, --check-redirects). .markdownlint.json still extends @ electron/lint-roller/configs/markdownlint.json, and the lockfile confirms the package resolves to npm:^4.0.0 with no broken peer resolution. This matches the PR description's claims.
Other factors
Already approved by dsanders11 (human reviewer) with no outstanding objections in the timeline. The change is mechanical, self-contained, and low risk, consistent with the approval guidelines for version bumps with no ambiguity.
Requested by David Sanders · Slack thread
Before:
@electron/lint-rollerwas pinned at^3.1.3(lockfile resolved 3.1.3), which still shipped the eslint-basedlint-roller-markdown-standardbin and its ~120-package eslint dependency tree.After:
@electron/lint-rolleris^4.0.0(lockfile resolves 4.0.0). No script changes were needed: the only lint-roller usage in this repo islint:links(lint-roller-markdown-links "*.md"), which uses none of the removed flags, and.markdownlint.jsonextends@electron/lint-roller/configs/markdownlint.json, which still exists.Notes
lint-roller-markdown-standardwas removed (replaced bylint-roller-markdown-oxlint). Not used here.lint-roller-markdown-linksdropped--fetch-external-linksand--check-redirects. Neither flag is used here.^22.17.0 || >=24.0.0..nvmrcis22.17,release.ymluses22.17.x, andcoveralls.ymluses22.x, so CI is fine.engines.nodeis>= 22.12.0, which is below the new floor; left unchanged in this PR but may be worth bumping separately.oxlint >= 1.65.0(satisfied by the existingoxlint@^1.81.0devDep) andoxfmt >= 0.20.0(not installed; only needed for the new optionallint-roller-markdown-oxfmtbin, which this repo does not use).yarn installemitted no lint-roller peer warnings.yarn lint:links,yarn lint:markdown, and the fullyarn lintall pass on Node 22.22.2.yarn.lock+43/-1302 lines (the eslint/standard tree is gone).package.jsonis a one-line change.🤖 Generated with Claude Code
https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
Generated by Claude Code