Repository navigation
fix: fetch Chromium install-build-deps from GitHub mirror - #102
Merged
Merged
Conversation
chromium.googlesource.com's gitiles web UI now returns 503 for scripted requests, so the ?format=TEXT downloads fail. Fetch the same pinned files from the chromium/chromium GitHub mirror instead, and use curl -f so a failed download breaks the build rather than writing an empty script. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015p7PNka9bMaQrBFYsiP9mS
jkleinsc
approved these changes
Sep 28, 2026
mlaurencin
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John Kleinschmidt · Slack thread
The gitiles web UI on chromium.googlesource.com now answers scripted requests with a Google 503 page, whatever the User-Agent. Because the old pipeline had no failure check, the build kept going with a garbage install-build-deps script. This PR downloads the same two files at the same pinned Chromium SHA from the official chromium/chromium GitHub mirror. I checked that their git blob hashes match the googlesource tree exactly. It also adds curl -f so a failed download stops the build instead of quietly skipping the Chromium deps, and it updates the comment on how to bump the SHA. The git protocol on googlesource still works, but a shallow fetch of chromium/src took more than six minutes and would need git in the image before this step, so I went with the mirror. I haven't run a full Docker image build here; this PR's CI will cover that.
🤖 Generated with Claude Code
https://claude.ai/code/session_015p7PNka9bMaQrBFYsiP9mS
Generated by Claude Code