You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From what I can tell, accomplishes the same as the awk usage without relying on the NUL byte behavior of particular versions of awk.
I didn't add any new tests because it relies on a specific version of awk to produce the issue, but all existing tests still pass aside from one, which failed prior to my change:
✗ merge: branches with encrypted file - line changes both branches, with conflicts
I was concerned the different approach might cause much slower performance, so I tested the impact by comparing the old awk command against this new read approach processing a list of over 30,000 NUL-delimited file entries.
On my system the new read approach is about 10 times slower to process the 30k entries, but still takes only about 0.88 seconds to do so while the awk approach takes about 0.08 seconds. It's a shame it's slower, but I think the impact is small enough even in repos with many files that the improved compatibility is worth the change.
Ah, interesting. Performance didn’t even cross my mind, good call. Thank you for the merges and transcrypt itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #213
From what I can tell, accomplishes the same as the awk usage without relying on the NUL byte behavior of particular versions of awk.
I didn't add any new tests because it relies on a specific version of awk to produce the issue, but all existing tests still pass aside from one, which failed prior to my change: