Skip to content

[8.19] [ML] Run QA and PyTorch suites concurrently in a single triggered build (#3131) - #3134

Open
edsavage wants to merge 1 commit into
elastic:8.19from
edsavage:backport/8.19/pr-3131
Open

[8.19] [ML] Run QA and PyTorch suites concurrently in a single triggered build (#3131)#3134
edsavage wants to merge 1 commit into
elastic:8.19from
edsavage:backport/8.19/pr-3131

Conversation

@edsavage

Copy link
Copy Markdown
Contributor

Manual backport of #3131 to 8.19.

The auto-backport failed on merge conflicts: 8.19 lacks the "Upload ES inference tests x86_64" step that sits directly above the QA-trigger block on main, so the hunk context could not anchor. The resolution also needed an extra import os in .buildkite/pipeline.json.py (8.19 did not previously import it, and the consolidated block reads QAF_TESTS_TO_RUN via os.environ).

No logic changes versus main. The consolidated single trigger emits a comma-separated QAF_TESTS_TO_RUN so the appex-qa generator fans QA (ml_cpp_pr) and PyTorch suites out into concurrent parallel jobs, and run_qa_tests.yml.sh derives its step label / commit-status context (QA / PyTorch / QA + PyTorch) from the requested suites.

Verified via dry-run on a fresh 8.19 checkout: pipeline.json.py runs and emits the correct single upload step + QAF_TESTS_TO_RUN for QA-only (ml_cpp_pr), PyTorch-only (pytorch_tests) and combined (ml_cpp_pr,pytorch_tests) cases; run_qa_tests.yml.sh passes bash -n and emits valid YAML with the correct label/context per case.

Made with Cursor

…lastic#3131)

Manual 8.19 backport of elastic#3131. The auto-backport conflicts because 8.19
lacks the "Upload ES inference tests x86_64" step that sits adjacent to
the QA-trigger block on main, so the hunk context cannot anchor.

Consolidates the separate run_qa_tests / run_pytorch_tests upload steps
into a single trigger with a comma-separated QAF_TESTS_TO_RUN, so the
appex-qa generator fans QA (ml_cpp_pr) and PyTorch suites out into
concurrent parallel jobs in one downstream build (avoiding the
skip_queued_branch_builds de-dup that dropped one of two separate
triggers). run_qa_tests.yml.sh now derives its step label and commit
status context (QA / PyTorch / QA + PyTorch) from the requested suites.

Adds "import os" to pipeline.json.py: 8.19 did not previously import it
and the consolidated block reads QAF_TESTS_TO_RUN via os.environ.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant