Skip to content

build(deps): align Gemfile.lock with lich-5 - #277

Merged
MahtraDR merged 2 commits into
elanthia-online:mainfrom
MahtraDR:deps/align-lockfile-with-lich5
Oct 30, 2026
Merged

MahtraDR merged 2 commits into
elanthia-online:mainfrom
MahtraDR:deps/align-lockfile-with-lich5

Conversation

@MahtraDR

@MahtraDR MahtraDR commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

This aligns Gemfile.lock with lich-5's, as part of keeping every Elanthia Online Ruby repo on lich-5's gem versions (elanthia-online/.github#5). The Gemfile doesn't change, and the other 22 gems the two projects share were already at the same versions.

  • curses 1.6.0 → 1.7.0. lich-5 locks 1.7.0 in its :profanity group, so users who install curses through lich-5 were running a different version from the one ProfanityFE tests against. The only code change between the two releases is on Windows: the bundled PDCurses was replaced with PDCursesMod. On Linux and macOS the extension is unchanged.
  • Bundler 4.0.8 → 4.0.23, matching lich-5 after chore(all): update sqlite3 to 2.10.2 and Bundler to 4.0.23 lich-5#2125. 4.0.23 is also the version Ruby 4.0.9 ships.
  • Platforms: lich-5's 20-platform list replaces arm64-darwin-25, which only matched one macOS version. ProfanityFE has no platform-specific gems, so this only changes which platforms the lockfile lists.

The lockfile was generated with bin/sync-lockfile from elanthia-online/.github#5.

Merge after elanthia-online/lich-5#2125. Until it merges, the Bundler version here is ahead of lich-5's main.

Tested locally with Bundler 4.0.23 in frozen mode, the way CI installs: rspec 4282 examples, 0 failures. Earlier runs on the same gem set: RuboCop 246 files with no offenses, and yard doc --fail-on-warning and check_yard_tags.rb both clean. I couldn't test curses 1.7.0 on Windows.

🤖 Generated with Claude Code

Bring the three lockfile settings that differed from lich-5 into line:

- curses 1.6.0 -> 1.7.0 (the version lich-5's :profanity group locks)
- Bundler 4.0.8 -> 4.0.20 (lich-5's BUNDLED WITH)
- PLATFORMS: lich-5's 20-platform list replaces the macOS-25-only
  arm64-darwin-25 entry

The Gemfile is unchanged, and every other gem was already at the same
version as lich-5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a75e34c9-637f-4bd0-b0b0-9029cb89a987

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Generated with elanthia-online/.github bin/sync-lockfile against
lich-5 #2125:
- Bundler 4.0.20 -> 4.0.23 (lich-5 moves to 4.0.23 in #2125)
- PLATFORMS: drop the generic ruby, which lich-5 doesn't list

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@mrhoribu mrhoribu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 002e334. Lockfile-only change; I checked it by running it, not just reading it.

  • Fresh worktree, Ruby 4.0.9, Bundler 4.0.23, BUNDLE_FROZEN=true BUNDLE_WITHOUT=gtk:vscode:profanity (the way CI installs): bundle install succeeds and compiles curses 1.7.0 natively against ncurses 6.6; the lockfile is unchanged afterwards.
  • bundle exec rspec: 4282 examples, 0 failures. rubocop: 246 files, no offenses. yard doc --fail-on-warning passes (the only output is the existing irb/notifier deprecation notice, which this PR doesn't touch). All CI checks are green.
  • The curses 1.7.0 sha256 matches lich-5's lockfile, and the PLATFORMS list matches lich-5's 20 entries exactly. The Gemfile is unchanged.

Non-blocking:

  1. Release gate for the merge: this should wait for elanthia-online/lich-5#2125, which is still open. Until it lands, 4.0.23 is ahead of lich-5 main's lockfile.
  2. Open question (author): dropping ruby from PLATFORMS means a frozen install on a platform outside the 20 listed (e.g. FreeBSD, riscv64) will be rejected until someone runs bundle lock --add-platform. I didn't test an unlisted platform. This matches lich-5, so I think it's acceptable. Can you confirm that's intended?
  3. As the description says, curses 1.7.0 on Windows (PDCursesMod) isn't tested by CI or by me.

Approving.

@MahtraDR
MahtraDR merged commit 65484c9 into elanthia-online:main Oct 30, 2026
6 checks passed
@MahtraDR
MahtraDR deleted the deps/align-lockfile-with-lich5 branch October 30, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants