Repository navigation
build(deps): align Gemfile.lock with lich-5 - #277
Merged
MahtraDR merged 2 commits intoOct 30, 2026
Merged
Conversation
Bring the three lockfile settings that differed from lich-5 into line: - curses 1.6.0 -> 1.7.0 (the version lich-5's :profanity group locks) - Bundler 4.0.8 -> 4.0.20 (lich-5's BUNDLED WITH) - PLATFORMS: lich-5's 20-platform list replaces the macOS-25-only arm64-darwin-25 entry The Gemfile is unchanged, and every other gem was already at the same version as lich-5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Generated with elanthia-online/.github bin/sync-lockfile against lich-5 #2125: - Bundler 4.0.20 -> 4.0.23 (lich-5 moves to 4.0.23 in #2125) - PLATFORMS: drop the generic ruby, which lich-5 doesn't list Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrhoribu
approved these changes
Oct 30, 2026
mrhoribu
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at 002e334. Lockfile-only change; I checked it by running it, not just reading it.
- Fresh worktree, Ruby 4.0.9, Bundler 4.0.23,
BUNDLE_FROZEN=true BUNDLE_WITHOUT=gtk:vscode:profanity(the way CI installs):bundle installsucceeds and compiles curses 1.7.0 natively against ncurses 6.6; the lockfile is unchanged afterwards. bundle exec rspec: 4282 examples, 0 failures.rubocop: 246 files, no offenses.yard doc --fail-on-warningpasses (the only output is the existing irb/notifier deprecation notice, which this PR doesn't touch). All CI checks are green.- The curses 1.7.0 sha256 matches lich-5's lockfile, and the PLATFORMS list matches lich-5's 20 entries exactly. The Gemfile is unchanged.
Non-blocking:
- Release gate for the merge: this should wait for elanthia-online/lich-5#2125, which is still open. Until it lands, 4.0.23 is ahead of lich-5 main's lockfile.
- Open question (author): dropping
rubyfrom PLATFORMS means a frozen install on a platform outside the 20 listed (e.g. FreeBSD, riscv64) will be rejected until someone runsbundle lock --add-platform. I didn't test an unlisted platform. This matches lich-5, so I think it's acceptable. Can you confirm that's intended? - As the description says, curses 1.7.0 on Windows (PDCursesMod) isn't tested by CI or by me.
Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns Gemfile.lock with lich-5's, as part of keeping every Elanthia Online Ruby repo on lich-5's gem versions (elanthia-online/.github#5). The Gemfile doesn't change, and the other 22 gems the two projects share were already at the same versions.
:profanitygroup, so users who install curses through lich-5 were running a different version from the one ProfanityFE tests against. The only code change between the two releases is on Windows: the bundled PDCurses was replaced with PDCursesMod. On Linux and macOS the extension is unchanged.arm64-darwin-25, which only matched one macOS version. ProfanityFE has no platform-specific gems, so this only changes which platforms the lockfile lists.The lockfile was generated with
bin/sync-lockfilefrom elanthia-online/.github#5.Merge after elanthia-online/lich-5#2125. Until it merges, the Bundler version here is ahead of lich-5's main.
Tested locally with Bundler 4.0.23 in frozen mode, the way CI installs: rspec 4282 examples, 0 failures. Earlier runs on the same gem set: RuboCop 246 files with no offenses, and
yard doc --fail-on-warningandcheck_yard_tags.rbboth clean. I couldn't test curses 1.7.0 on Windows.🤖 Generated with Claude Code