Repository navigation
test: cover invalid index items in SitemapAndIndexStream - #523
Merged
Merged
Conversation
The fix for #517 already landed in 68f6808 with a test for an invalid index URL at ErrorLevel.THROW. This adds the missing cases: - an invalid index lastmod at THROW fails the stream - neither rejected item leaves a <sitemap> entry in the index output - at WARN and SILENT, the sitemap stays listed without its lastmod Closes #517 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517.
The fix itself already landed in 68f6808:
addToIndexreports the index item error, and the CHANGELOG already has an entry for it. That commit included a test for an invalid index URL atErrorLevel.THROW, but not the other cases the issue asks for.Changes
THROW: a non-http(s) URL and an invalidlastmod.<sitemap>entry for the rejected item.WARNandSILENTthe sitemap stays in the index without its<lastmod>, and that a warning is logged only atWARN.Testing
npm test: 530 tests pass. Lint, Prettier andtsc --noEmitare clean.addToIndexremoved, bothTHROWtests fail.🤖 Generated with Claude Code