Skip to content

Add void return type to load() method #32

Description

@josuna

[Enhancement] Add void return type to load() method

Current Behavior

The load() method in PhpSpreadsheetExtension doesn't have a return type declaration, which causes warnings in Symfony 6.4.

Expected Behavior

The load() method should have a void return type declaration to maintain compatibility with Symfony 6.4.

Warning Message

"Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Yectep\PhpSpreadsheetBundle\DependencyInjection\PhpSpreadsheetExtension" now to avoid errors or add an explicit @return annotation to suppress this message."

Proposed Solution

Add void return type to the load() method:

public function load(array $configs, ContainerBuilder $container): void
{
    // existing code
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions