feat(timeline):#IMPULS-6021-customizationPreview - #1124
Merged
Merged
Conversation
damienromito
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
2 times, most recently
from
August 28, 2026 16:27
5137065 to
fbf30d0
Compare
damienromito
force-pushed
the
feat-IMPULS-6253-mock-timeline
branch
2 times, most recently
from
September 3, 2026 12:01
7ceeafc to
4fcbfa3
Compare
damienromito
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
from
September 3, 2026 12:27
fbf30d0 to
65a3800
Compare
Base automatically changed from
feat-IMPULS-6253-mock-timeline
to
feat-IMPULS-6022
September 3, 2026 12:36
damienromito
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
from
September 3, 2026 12:41
65a3800 to
cbe0ed1
Compare
damienromito
changed the title
damienromito
requested review from
jcbe-ode
and
a balanced review from Copilot
and removed request for
Copilot
September 3, 2026 16:14
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Moderate font-token, accessibility, and Corsican flag issues remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a responsive customization preview to Timeline’s frontend.
Changes:
- Previews selected language and dyslexic font.
- Adds localized preview content, styling, fixtures, and tests.
- Integrates the preview into the customization page.
File summaries
| File | Review |
|---|---|
timeline/frontend/src/routes/pages/customize/customize.tsx |
Integrates the responsive preview. |
timeline/frontend/src/routes/pages/customize/customize.css |
Removes obsolete sidebar styling. |
timeline/frontend/src/models/customization.ts |
Defines preview text and font metadata. |
timeline/frontend/src/mocks/platform/data/customize.ts |
Expands fixtures; moderate: Corsican currently resolves to the Colombian flag and needs an explicit mapping or asset. |
timeline/frontend/src/components/CustomizationPreview/CustomizationPreview.tsx |
Implements the preview; moderate: decorative content must be hidden from assistive technology. Nit: rename selecterFontName to selectedFontName. |
timeline/frontend/src/components/CustomizationPreview/CustomizationPreview.test.tsx |
Tests preview text and font behavior. |
timeline/frontend/src/components/CustomizationPreview/CustomizationPreview.css |
Styles the preview; moderate: replace unresolved --primitive-font-family-title with --font-family-title. |
timeline/frontend/.prettierignore |
Excludes generated MSW output. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * Fixtures for GET /languages and GET /themes (page /customize). | ||
| */ | ||
| export const mockLanguages = ['fr', 'en', 'es']; | ||
| export const mockLanguages = ['fr', 'en', 'es', 'de', 'pt', 'it', 'co']; |
Member
Author
There was a problem hiding this comment.
@jcbe-ode ce commentaire est pertinent,
https://flagcdn.com/w80/co.png renvoit le drapeau de la colombie (appelé ici https://github.com/edificeio/entcore/blob/feat-IMPULS-6021-customizePreview/timeline/frontend/src/components/CustomizationForm/CustomizationForm.tsx#L97 )
Pourtant je vois que "co" est bien le code langue de la corse https://fr.wikipedia.org/wiki/Liste_des_codes_ISO_639-1
Il faudra voir comment contourner ce probleme. Utilisant notre propre helper côté FF
(cf @pascalsaussier-edifice )
Contributor
There was a problem hiding this comment.
Il y a déjà un adaptateur, on a fait une exception similaire pour le drapeau anglais : notre code langue c'est en, mais le drapeau c'est gb.png.
=> J'applique la même chose pour le corse.
Contributor
There was a problem hiding this comment.
...sauf qu'il ne l'ont pas :-/
Vu que c'est un sujet à part du composant de prévisualisation, je propose de le traiter ailleurs.
jcbe-ode
force-pushed
the
feat-IMPULS-6022
branch
from
September 4, 2026 07:35
3396da3 to
0963466
Compare
damienromito
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
from
September 7, 2026 07:13
2ce1657 to
48dba3c
Compare
jcbe-ode
force-pushed
the
feat-IMPULS-6022
branch
from
September 7, 2026 13:11
6b4cc8c to
2a07896
Compare
jcbe-ode
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
from
September 7, 2026 13:23
48dba3c to
5ac0b49
Compare
…dynamiques CustomizationPreview reçoit désormais selecterFontName et selectedLanguage depuis le formulaire ; la conversion vers la classe de police (ff-dyslexic) et vers les textes traduits se fait dans le composant. Les traductions de l'aperçu sont codées en dur (7 langues) faute de mécanisme de fetch par langue côté i18n, avec repli sur le français.
jcbe-ode
force-pushed
the
feat-IMPULS-6021-customizePreview
branch
from
September 8, 2026 14:57
5ac0b49 to
b5a0062
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
vbillard91
pushed a commit
that referenced
this pull request
Sep 9, 2026
* feat(timeline):#IMPULS-6021-customizePreview fix css * fix merge * add font customization * fix css * add language custom * feat(timeline): #IMPULS-6021 rend la police et la langue de l'aperçu dynamiques CustomizationPreview reçoit désormais selecterFontName et selectedLanguage depuis le formulaire ; la conversion vers la classe de police (ff-dyslexic) et vers les textes traduits se fait dans le composant. Les traductions de l'aperçu sont codées en dur (7 langues) faute de mécanisme de fetch par langue côté i18n, avec repli sur le français. * show selected background * update tests * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix language img size --------- Co-authored-by: jcbe-ode <jean-christophe.benoit@opendigitaleducation.com> Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
vbillard91
pushed a commit
that referenced
this pull request
Sep 16, 2026
* feat(timeline):#IMPULS-6021-customizePreview fix css * fix merge * add font customization * fix css * add language custom * feat(timeline): #IMPULS-6021 rend la police et la langue de l'aperçu dynamiques CustomizationPreview reçoit désormais selecterFontName et selectedLanguage depuis le formulaire ; la conversion vers la classe de police (ff-dyslexic) et vers les textes traduits se fait dans le composant. Les traductions de l'aperçu sont codées en dur (7 langues) faute de mécanisme de fetch par langue côté i18n, avec repli sur le français. * show selected background * update tests * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix language img size --------- Co-authored-by: jcbe-ode <jean-christophe.benoit@opendigitaleducation.com> Co-authored-by: jcbe-ode <67910608+jcbe-ode@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implémente le composant
CustomizePreview(partie droite de la page de personnalisation/timeline/customize) : aperçu miniature de la page d'accueil, piloté par le formulaire de personnalisation.aria-hidden.selecterFontName: bascule la classeff-dyslexic(fournie par@edifice.io/bootstrap) sur l'aperçu quand la police dyslexique est sélectionnée dans le formulaire — sans attendre l'enregistrement.selectedLanguage: traduit les 2 textes de l'aperçu selon la langue sélectionnée dans le formulaire (pas encore enregistrée), via un petit dictionnaire codé en dur (7 langues : fr/en/es/de/pt/it/co) avec repli sur le français. Codé en dur faute de mécanisme de fetch de traduction par langue côté i18n (src/i18n.tsroute toutes les langues vers la même URL, résolue côté back par la session) — le vrai branchement aux traductions officielles est laissé à IMPULS-6022.md(comportement existant, non modifié).Fixes
IMPULS-6021
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
pnpm --filter timeline test(Vitest) :CustomizationPreview.test.tsxcouvre le rendu par défaut (fr), une langue traduite (en), le repli sur langue inconnue, l'absence d'élément focusable, et la classeff-dyslexicselonselecterFontName.pnpm dev:mocksur/customize: changer la police dans le formulaire bascule en direct la police de l'aperçu ; changer la langue bascule en direct les textes de l'aperçu.Reminder
Security flaws : aucun identifié — composant de présentation pur, pas de nouvel endpoint, pas d'entrée utilisateur libre
Performance impacts (think bulk !) : négligeable — table de correspondance statique, aucun appel réseau supplémentaire
Unit tests were replayed : oui
Unit tests were added and/or changed : oui
I have updated the reminder for the version including my modifications : à vérifier par l'auteur
All done ! 😃