Skip to content

[fix] Remove unused aria-disabled prop on menu items #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AxelRICHARD merged 1 commit into from
Jul 23, 2026
Merged

[fix] Remove unused aria-disabled prop on menu items #2357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...yson-components/src/extensions/InsertTextualSysMLv2ExplorerToolOverriddenContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export const InsertTextualSysMLv2ExplorerToolOverriddenContribution = forwardRef
onClick={() => setModal(true)}
data-testid="insert-textual-sysmlv2-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<AddIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions frontend/syson-components/src/extensions/InsertTextualSysMLv2MenuContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export const InsertTextualSysMLMenuContribution = forwardRef(
onClick={() => setModal(true)}
data-testid="insert-textual-sysmlv2-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<AddIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions ...ponents/src/extensions/expressions/DeleteExpressionExplorerToolOverriddenContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ export const DeleteExpressionExplorerToolOverriddenContribution = forwardRef(
onClick={handleDeleteExpression}
data-testid="delete-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<DeleteIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions ...end/syson-components/src/extensions/expressions/DeleteSysMLExpressionMenuContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ export const DeleteSysMLExpressionMenuContribution = forwardRef(
onClick={handleDeleteExpression}
data-testid="delete-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<DeleteIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions ...omponents/src/extensions/expressions/EditExpressionExplorerToolOverriddenContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export const EditExpressionExplorerToolOverriddenContribution = forwardRef(
onClick={() => setModalOpened(true)}
data-testid="edit-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<EditIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions frontend/syson-components/src/extensions/expressions/EditSysMLExpressionMenuContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export const EditSysMLExpressionMenuContribution = forwardRef(
onClick={() => setModalOpened(true)}
data-testid="edit-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<EditIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions ...components/src/extensions/expressions/NewExpressionExplorerToolOverriddenContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export const NewExpressionExplorerToolOverriddenContribution = forwardRef(
onClick={() => setModalOpened(true)}
data-testid="new-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<AddIcon fontSize="small" />
</ListItemIcon>
Expand Down
3 changes: 1 addition & 2 deletions frontend/syson-components/src/extensions/expressions/NewSysMLExpressionMenuContribution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export const NewSysMLExpressionMenuContribution = forwardRef(
onClick={() => setModalOpened(true)}
data-testid="new-sysml-expression-menu"
disabled={readOnly}
ref={ref}
aria-disabled>
ref={ref}>
<ListItemIcon>
<AddIcon fontSize="small" />
</ListItemIcon>
Expand Down
Loading