Migrate SCT verbose filter and datarouter filter tests to integration by RSingh1511 · Pull Request #117 · eclipse-score/logging

RSingh1511 · 2026-05-20T07:33:38Z

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-05-20T07:34:19Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a48a3121-7e2d-488d-a4dd-867665d60b97
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 7.754s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-05-20T07:56:21Z

The created documentation from the pull request is available at: docu-html

rmaddikery · 2026-05-22T13:21:34Z

+filegroup(
+    name = "integration_test_config_files",
+    srcs = [
+        "etc/log-channels.json",


Suggested change

"etc/log-channels.json",

this file is missing. so why include?

The file exists at score/datarouter/etc/log-channels.json.

rmaddikery · 2026-05-22T13:23:05Z

+    srcs = [
+        "etc/log-channels.json",
+        "etc/logging.json",
+        "etc/raw-channels.json",


Same as https://github.com/eclipse-score/logging/pull/117/changes#r3288650426

The file exists at score/datarouter/etc/raw-channels.json

rmaddikery · 2026-05-26T08:17:48Z

        "//platform/aas/tools/sctf:__subpackages__",
        "//pqr/abc/abc-lmn/config/project/cpu/pas/datarouter:__pkg__",
        "//score/datarouter/test:__subpackages__",
+        "//score/test/component:__subpackages__",


Why do you need this? Instead expose only what is required for the test.

rmaddikery · 2026-05-26T08:18:06Z

+    ],
+)
+
+filegroup(


move this to test/component folder itself

rmaddikery · 2026-05-26T08:18:56Z

    visibility = [
        "//platform/aas/ara/log:__subpackages__",
        "//score/mw/log:__subpackages__",
+        "//score/test/component:__subpackages__",


deps on @score_baselibs//mw/log:log should be sufficient!

- Move score/test/integration/ -> score/test/component/ to distinguish from nightly integration tests (reviewer: rmaddikery) - Rename integration_config_files -> integration_test_config_files in score/datarouter/BUILD (reviewer: rmaddikery) - Remove custom dlt_parser.py; refactor all tests to use DltLogRecord from score_itf (score.itf.plugins.dlt.dlt_window) via download_dlt() helper in logging_plugin.py (reviewer: rmaddikery)

rmaddikery · 2026-05-27T12:21:29Z

            //... \
-            -//:*
+            -//:* \
+            -//score/test/component/...


This should not be a problem, but its better to skipped here since it will be built and executed in component tests workflow!

Since they are component tests run only in the host environment

RSingh1511 requested a deployment to workflow-approval May 20, 2026 07:33 — with GitHub Actions Waiting

RSingh1511 changed the title ~~Migrate SCT verbose filter and datarouter filter tests to integration…~~ Migrate SCT verbose filter and datarouter filter tests to integration May 20, 2026

RSingh1511 requested a deployment to workflow-approval May 20, 2026 07:49 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from e6c1841 to 56e3195 Compare May 20, 2026 07:52

RSingh1511 requested a deployment to workflow-approval May 20, 2026 07:52 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from 56e3195 to 669dd9f Compare May 20, 2026 07:57

RSingh1511 requested a deployment to workflow-approval May 20, 2026 07:57 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from 669dd9f to f3cf43a Compare May 20, 2026 08:06

RSingh1511 requested a deployment to workflow-approval May 20, 2026 08:06 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from f3cf43a to bb37dde Compare May 20, 2026 09:15

RSingh1511 requested a deployment to workflow-approval May 20, 2026 09:15 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch 2 times, most recently from bb37dde to 40b7b56 Compare May 20, 2026 09:22

RSingh1511 requested a deployment to workflow-approval May 20, 2026 09:22 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from 40b7b56 to 6334c84 Compare May 20, 2026 10:08

RSingh1511 requested a deployment to workflow-approval May 20, 2026 10:08 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from 6334c84 to 785ed2e Compare May 20, 2026 10:20

RSingh1511 requested a deployment to workflow-approval May 20, 2026 10:20 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from 785ed2e to 1f106fa Compare May 20, 2026 10:48

RSingh1511 requested a deployment to workflow-approval May 21, 2026 12:31 — with GitHub Actions Waiting

RSingh1511 force-pushed the rs/sctf_migration branch from e5213ee to 7336289 Compare May 21, 2026 12:38

RSingh1511 requested a deployment to workflow-approval May 21, 2026 12:38 — with GitHub Actions Waiting

rmaddikery reviewed May 22, 2026

View reviewed changes

Comment thread .bazelrc Outdated

rmaddikery reviewed May 22, 2026

View reviewed changes

Comment thread score/test/component/datarouter/test_filetransfer.py Outdated

rmaddikery reviewed May 22, 2026

View reviewed changes

Comment thread score/datarouter/build_configuration_flags/BUILD Outdated

rmaddikery reviewed May 22, 2026

View reviewed changes

rmaddikery reviewed May 26, 2026

View reviewed changes

HiLivin and others added 17 commits May 26, 2026 13:23

Add score_itf and OCI build dependencies

48d3a57

Suppress score_baselibs deprecation warnings

463c155

Add shared ITF infrastructure for logging integration tests

0f72360

Add mw_log integration tests

9d64278

Add mw_log kFile integration tests

61bcbee

Add verbose log-level filter integration tests

bd0825a

Add non-verbose (TRACE) filter integration test

343ecf2

Add DLT filetransfer integration test

fe5c1b1

Fix review findings

4e822ee

resolve CI build failures

e1adbd2

fix dlt_daemon compilation warnings

f65778a

restructure component tests and add separate workflow

5013efc

enable component tests on PR for validation

5e980fd

move filetransfer into datarouter, enable nonverbose dlt

61ae3f7

split component tests into PR and nightly workflows

54ed218

move config files to test folder

ccbf31c

rmaddikery reviewed May 27, 2026

View reviewed changes

Exclude component tests from production sw build workflows

9515c5c

Since they are component tests run only in the host environment

Conversation

RSingh1511 commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RSingh1511 commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 20, 2026 •

edited

Loading