Dispose leftover shells in WorkbenchContextExtension cleanup#3894
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 16, 2026
Merged
Conversation
The dispose() method calls wb.close() which removes GUI for application windows, but does not dispose shells created as side effects (e.g. PartRenderingEngine's limbo shell). These accumulate across test methods, causing many unexpected windows to open. Explicitly dispose all remaining shells after wb.close() to ensure a clean state between test methods. See eclipse-platform#3893
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkbenchContextExtensiontest cleanupwb.close()removes GUI for application windows but does not dispose shells created as side effects (e.g.,PartRenderingEngine's limbo shell)wb.close()to ensure a clean state between test methodsSee #3893
Test plan
PartOnTopManagerTest(6 tests) — all passWorkbenchContextExtension(182 tests) — no regressions (pre-existing failures inMWindowTestandPartRenderingEngineTestsare unchanged)PartRenderingEngine's limboshell that the new cleanup correctly disposes