Skip to content

Searching now bumps matches based on exact match ranking - #2237

Open
ebkr wants to merge 4 commits into
developfrom
fix/TS-4025/exact-search-matches
Open

Searching now bumps matches based on exact match ranking#2237
ebkr wants to merge 4 commits into
developfrom
fix/TS-4025/exact-search-matches

Conversation

@ebkr

@ebkr ebkr commented Jul 10, 2026

Copy link
Copy Markdown
Owner

No description provided.

@ebkr
ebkr requested a review from x753 July 10, 2026 05:10

@x753 x753 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are functional but I don't agree with them. If I'm browsing by highest rated and I search for suits, the first results shouldn't be every mod named suits or every package by a team named suits, especially without anything separating them from the actual highly rated results.

My recommendation is to change the default sort behavior of the mod manager to a new sort mode called Relevant, which would be the same as last updated except with the exact match ranking bumps.

@ebkr

ebkr commented Jul 20, 2026

Copy link
Copy Markdown
Owner Author

That's fair, I didn't consider that.

Sort by Relevant is a good idea

Comment thread src/model/enums/SortingStyle.ts Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "Default" sort mode just be "Relevance"? Having it just be "Default" means it's just a black box what's actually happening.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default is just matching TS.
It's not clear, but the search behaviour is basically just in order of last updated + pinned.

The alternative is to drop "Relevance" again and instead make the bumping work only on "Default" sort behaviour?

@x753 x753 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good how it is now.

I think it would be worthwhile to expand the match ranking to treat _ the same as a space, so "More Suits" would show "More_Suits" as the first result for Lethal Company.

@ebkr
ebkr force-pushed the fix/TS-4025/exact-search-matches branch from 1e06beb to ba16242 Compare July 30, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants