Support blk reservation#680
Conversation
Application has an option to reserve some blks in a chunk when allocation.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
+ Coverage 56.51% 66.02% +9.51%
==========================================
Files 108 109 +1
Lines 10300 11348 +1048
Branches 1402 1545 +143
==========================================
+ Hits 5821 7493 +1672
+ Misses 3894 3124 -770
- Partials 585 731 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sorry, I have a small question. If space is reserved at the HS level, does this mean that followers also reserve this space? In that case, when a follower has garbage, would it still trigger a NO_SPACE_LEFT condition, causing the PG state to become unclean? Or will there be some modifications at the upper layer to prevent this issue? |
|
It has to be done in HS as from HO's point of view, if it get a multiBlk it has no way to know how much space still available on the chunk --- this is specific to allocator. But what you said makes sense, the reservation is done through allocation_hint CB. We aware we should set no reservation for seal shard, thanks for reminding we need to consider the role here |
Application has an option to reserve some blks in a chunk when allocation.