Repository navigation
Conversation
Fix Result.toJSON() and Execution.to_json() to preserve the data field when present, including empty objects. Previously, the JS SDK omitted data entirely from serialization, and the Python SDK dropped empty data objects due to a truthiness check in formats(). - JS: Add data field to toJSON() when not undefined - Python: Change data truthiness check to is not None in formats() - Add tests for both SDKs covering populated, empty, and undefined data Fixes e2b-dev#1938 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
We require contributors to sign our Contributor License Agreement, and we don't have @YidaWeng on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
🦋 Changeset detectedLatest commit: e590562 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Summary
Test plan
Example
Fixes #1938
Generated with Devin