Repository navigation
fix(code-interpreter-python): release e2b get_sandbox_url port and require e2b>=2.55.1 #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@e2b/code-interpreter-python': patch | ||
| --- | ||
|
|
||
| Require `e2b>=2.55.1`, the first release with `get_sandbox_url(..., port=)`. 2.10.4 failed with `TypeError: ... unexpected keyword argument 'port'` when installed with e2b 2.55.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@e2b/python-sdk': patch | ||
| --- | ||
|
|
||
| `ConnectionConfig.get_sandbox_url` / `get_sandbox_direct_url` take an optional `port` (defaults to the envd port). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) PyPI users can get an e2b-code-interpreter 2.10.5 that cannot be installed if the e2b 2.55.1 upload in the same release fails or lands later. The release runs
pnpm run -r postPublish, and code-interpreter-python's package.json declares no dependency on @ e2b/python-sdk. pnpm therefore does not make it wait for the e2b upload. Fix: make sure e2b 2.55.1 is on PyPI before 2.10.5 is uploaded. One way is adding"@ e2b/python-sdk": "workspace:*"to packages/code-interpreter-python/package.json dependencies, as python-sdk already does for dockerfile-utils-python.Why this was flagged
The trigger is the Release run this PR asks for. The publish script in root package.json is
pnpm run -r postPublish, and each Python package's postPublish runsuv build && uv publish. pnpm -r orders packages only by package.json dependencies. packages/code-interpreter-python/package.json has no dependencies, so its upload runs in the first concurrent batch, before python-sdk's. Line 12 now requirese2b>=2.55.1, a version only this same run creates. On base, the floor>=2.55.0was already on PyPI, so upload order did not matter. If the e2b upload fails or is delayed, 2.10.5 stays on PyPI requiring a missing e2b, and the version cannot be re-uploaded. Thenpip install e2b-code-interpreter==2.10.5fails to resolve, and unpinned installs fall back to the broken 2.10.4.uv publish --check-urlonly skips identical files and does not order uploads.Verification: nit. pyproject.toml line 12 now requires
e2b>=2.55.1,<3.0.0, and that version only exists once this same run uploads it.packages/code-interpreter-python/package.jsondeclares no dependencies, so itsuv build && uv publish ...runs in the first batch, before or alongside python-sdk's upload. So 2.10.5 can land on PyPI before e2b 2.55.1 exists.