Repository navigation
chore(deps-dev): bump the uv group across 3 directories with 1 update - #1965
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the uv group with 1 update in the /packages/code-interpreter-python directory: [datamodel-code-generator](https://github.com/datamodel-code-generator/datamodel-code-generator). Bumps the uv group with 1 update in the /packages/desktop-python directory: [datamodel-code-generator](https://github.com/datamodel-code-generator/datamodel-code-generator). Bumps the uv group with 1 update in the /packages/python-sdk directory: [datamodel-code-generator](https://github.com/datamodel-code-generator/datamodel-code-generator). Updates `datamodel-code-generator` from 0.64.0 to 0.81.0 - [Release notes](https://github.com/datamodel-code-generator/datamodel-code-generator/releases) - [Changelog](https://github.com/datamodel-code-generator/datamodel-code-generator/blob/main/CHANGELOG.md) - [Commits](datamodel-code-generator/datamodel-code-generator@0.64.0...0.81.0) Updates `datamodel-code-generator` from 0.64.0 to 0.81.0 - [Release notes](https://github.com/datamodel-code-generator/datamodel-code-generator/releases) - [Changelog](https://github.com/datamodel-code-generator/datamodel-code-generator/blob/main/CHANGELOG.md) - [Commits](datamodel-code-generator/datamodel-code-generator@0.64.0...0.81.0) Updates `datamodel-code-generator` from 0.64.0 to 0.81.0 - [Release notes](https://github.com/datamodel-code-generator/datamodel-code-generator/releases) - [Changelog](https://github.com/datamodel-code-generator/datamodel-code-generator/blob/main/CHANGELOG.md) - [Commits](datamodel-code-generator/datamodel-code-generator@0.64.0...0.81.0) --- updated-dependencies: - dependency-name: datamodel-code-generator dependency-version: 0.81.0 dependency-type: direct:development dependency-group: uv - dependency-name: datamodel-code-generator dependency-version: 0.81.0 dependency-type: direct:development dependency-group: uv - dependency-name: datamodel-code-generator dependency-version: 0.81.0 dependency-type: direct:development dependency-group: uv ... Signed-off-by: dependabot[bot] <support@github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
I didn't add a changeset to PR #1965 because nothing in it changes how a published package behaves. The PR touches two files:
I made no commits to the PR. |
There was a problem hiding this comment.
Devin Review found 2 potential issues.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
🟡 SDK codegen lock retains old generator
With the new pin, uv sync --frozen --group codegen still installs 0.64.0 from the SDK lock. uv sync --locked --group codegen rejects the mismatched lock instead.
Learn more
The SDK maintains its own lockfile, separate from the code-interpreter workspace lockfile. The SDK lock still specifies 0.64.0 for both the generator package and its codegen requirement. Frozen installs trust that lock without checking the project pin, while locked installs require an up-to-date lock. This prevents either mode from using the new pin as intended.
Example: An SDK developer runs uv sync --frozen --group codegen after pulling this PR. The installed generator remains 0.64.0 rather than the requested 0.81.0.
Recommended fix: Refresh and commit packages/python-sdk/uv.lock with uv from the SDK project directory, then check that its codegen metadata and generator package both resolve to 0.81.0.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
🟡 MCP generation differs between local and Docker workflows
After make init, local generate-mcp uses 0.81.0, but codegen.Dockerfile still installs 0.64.0 for make codegen. The two generation workflows can produce different MCP models from the same schema.
Learn more
The SDK codegen group supplies datamodel-codegen to the local generate-mcp target. The root make codegen target instead launches make generate in an image built from codegen.Dockerfile, which installs a separate pin of 0.64.0. Updating only the local pin leaves those two workflows on different generator releases, so outputs may diverge as their generation behavior changes.
Example: A developer runs make init and then uv run make generate-mcp; another runs the root make codegen on the same spec. They invoke versions 0.81.0 and 0.64.0 respectively, despite expecting reproducible generated files.
Recommended fix: Update the datamodel-code-generator pin in codegen.Dockerfile alongside the SDK codegen group, and regenerate and compare the MCP output under the updated image.
Was this helpful? React with 👍 or 👎 to provide feedback.
Package ArtifactsBuilt from e95462d. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.1-dependabot-uv-packages-code-interpreter-python-uv-940ece5b2b.0.tgz ./e2b-2.54.1-dependabot-uv-packages-code-interpreter-python-uv-940ece5b2b.0.tgzCLI ( npm install ./e2b-cli-2.21.2-dependabot-uv-packages-code-interpreter-python-uv-940ece5b2b.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.8.3-dependabot-uv-packages-code-interpreter-python-uv-940ece5b2b.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.4.1-dependabot-uv-packages-code-interpreter-python-uv-940ece5b2b.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.0+dependabot.uv.packages.code.interpreter.python.uv.940ece5b2b-py3-none-any.whl ./e2b-2.54.0+dependabot.uv.packages.code.interpreter.python.uv.940ece5b2b-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.10.3+dependabot.uv.packages.code.interpreter.python.uv.940ece5b2b-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.6.1+dependabot.uv.packages.code.interpreter.python.uv.940ece5b2b-py3-none-any.whl |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df22b3c280
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
Refresh every workspace lockfile after the dependency bump
The Python SDK is a member of both downstream Python workspaces, but only packages/code-interpreter-python/uv.lock was refreshed; packages/python-sdk/uv.lock:154,229 and packages/desktop-python/uv.lock:326,401 still pin 0.64.0. The Python SDK and desktop workflows run uv sync --locked (python_sdk_tests.yml:48 and desktop_python_tests.yml:48), and uv sync --help defines --locked as asserting that uv.lock remains unchanged, so these jobs will reject the stale locks instead of installing 0.81.0. Regenerate both remaining lockfiles with uv.
AGENTS.md reference: AGENTS.md:L1-L1
Useful? React with 👍 / 👎.
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
Keep the containerized codegen pin synchronized
The authoritative make codegen path and the generated-files workflow build codegen.Dockerfile, whose install command still pins datamodel-code-generator==0.64.0 at line 24. Consequently CI continues generating with 0.64.0 while the local codegen group requests 0.81.0, violating the synchronization invariant documented immediately above this change and allowing local and CI generation to produce different output; update the Dockerfile pin alongside this one.
Useful? React with 👍 / 👎.
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
🔴 Python SDK and desktop CI jobs that run uv sync --locked will fail after merge, because two lockfiles still record the old pin. packages/python-sdk/uv.lock:229 and packages/desktop-python/uv.lock:401 still say datamodel-code-generator ==0.64.0. Only packages/code-interpreter-python/uv.lock was regenerated. Fix: run uv lock in packages/python-sdk and packages/desktop-python as well, so all three locks that include python-sdk's codegen group record ==0.81.0.
Why this was flagged
pyproject.toml:51 now pins datamodel-code-generator==0.81.0. packages/python-sdk/uv.lock:229 still has specifier = "==0.64.0". packages/desktop-python/uv.lock:401 has the same stale specifier through its editable python-sdk dependency. uv sync --locked exits with an error when the lock no longer matches pyproject. CI runs it in .github/workflows/python_sdk_tests.yml:48, typecheck.yml:78, lint.yml:82 and desktop_python_tests.yml:48. On the base branch these locks matched pyproject and those jobs passed. The dependabot description says three directories were bumped, but only code-interpreter-python's lock is in the diff.
Verification: Trigger: any CI job that runs uv sync --locked once this merges. packages/python-sdk/uv.lock:229 still has { name = "datamodel-code-generator", specifier = "==0.64.0" }, and packages/desktop-python/uv.lock:401 has the same stale specifier. On the base commit the specifiers matched pyproject, so this is a regression that breaks the lint, typecheck and test CI jobs.
| "black==26.3.1", | ||
| "e2b-openapi-python-client==0.26.2", | ||
| "datamodel-code-generator==0.64.0", | ||
| "datamodel-code-generator==0.81.0", |
There was a problem hiding this comment.
🟡 (optional) Code generated locally will now differ from the CI-checked output, because the local tool pin no longer matches the Docker image. The comment at pyproject.toml:44 says these pins mirror codegen.Dockerfile. codegen.Dockerfile:24 still installs datamodel-code-generator==0.64.0, while the codegen group now uses 0.81.0. Fix: bump codegen.Dockerfile:24 to 0.81.0 too, then regenerate with make codegen (e.g. e2b/sandbox/mcp.py) so generated_files.yml passes. Otherwise, keep both pins at 0.64.0.
Why this was flagged
The Makefile:19 make codegen target builds codegen.Dockerfile, which pins datamodel-code-generator==0.64.0 at line 24. The generated_files.yml workflow uses that image to check committed output. After this change, a developer running make init and uv run make generate-* (packages/python-sdk/Makefile:32 runs uv sync --group codegen) gets 0.81.0. 0.81.0 has breaking code-generation changes listed in the 0.80.0/0.81.0 release notes. Regenerated files such as e2b/sandbox/mcp.py can then differ from what CI's 0.64.0 image produces, so the generated-files check fails. On the base branch both pins were 0.64.0, so local and CI output matched, as the comment at pyproject.toml:44 promises.
Verification: packages/python-sdk/pyproject.toml:44 says "Pins mirror codegen.Dockerfile so local output matches CI", and line 51 now reads "datamodel-code-generator==0.81.0". codegen.Dockerfile:24 still runs pip install ... datamodel-code-generator==0.64.0 .... .github/workflows/generated_files.yml:81-136 builds that image, runs make codegen and then git diff to check committed output.
Bumps the uv group with 1 update in the /packages/code-interpreter-python directory: datamodel-code-generator.
Bumps the uv group with 1 update in the /packages/desktop-python directory: datamodel-code-generator.
Bumps the uv group with 1 update in the /packages/python-sdk directory: datamodel-code-generator.
Updates
datamodel-code-generatorfrom 0.64.0 to 0.81.0Release notes
Sourced from datamodel-code-generator's releases.
... (truncated)
Changelog
Sourced from datamodel-code-generator's changelog.
... (truncated)
Commits
be170f7docs: update release benchmark data (#4053)5492ae9Fix payload runtime compatibility (#4063)4401cc7Guard output policy and private parser boundaries (#4060)6c800fcMove output configuration out of parsers (#4059)203d5b2Move output model decisions out of parsers (#4058)45df98aShare JSON Schema reference rewriting across inputs (#4057)19b9465Fix required validation in request and response models (#4055)0966214Fix parser template data reuse (#4054)5e94b8fMerge commit from fork834731ddocs: update release benchmark data (#4052)Updates
datamodel-code-generatorfrom 0.64.0 to 0.81.0Release notes
Sourced from datamodel-code-generator's releases.
... (truncated)
Changelog
Sourced from datamodel-code-generator's changelog.
... (truncated)
Commits
be170f7docs: update release benchmark data (#4053)5492ae9Fix payload runtime compatibility (#4063)4401cc7Guard output policy and private parser boundaries (#4060)6c800fcMove output configuration out of parsers (#4059)203d5b2Move output model decisions out of parsers (#4058)45df98aShare JSON Schema reference rewriting across inputs (#4057)19b9465Fix required validation in request and response models (#4055)0966214Fix parser template data reuse (#4054)5e94b8fMerge commit from fork834731ddocs: update release benchmark data (#4052)Updates
datamodel-code-generatorfrom 0.64.0 to 0.81.0Release notes
Sourced from datamodel-code-generator's releases.
... (truncated)
Changelog
Sourced from datamodel-code-generator's changelog.
... (truncated)
Commits
be170f7docs: update release benchmark data (#4053)5492ae9Fix payload runtime compatibility (#4063)4401cc7Guard output policy and private parser boundaries (#4060)6c800fcMove output configuration out of parsers (#4059)203d5b2Move output model decisions out of parsers (#4058)45df98aShare JSON Schema reference rewriting across inputs (#4057)19b9465Fix required validation in request and response models (#4055)0966214Fix parser template data reuse (#4054)5e94b8fMerge commit from fork834731ddocs: update release benchmark data (#4052)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.