Skip to content

fix(deps): bump sharp override to ^0.35.5 (GHSA-wq5f-xc86-pv6w) - #1952

Closed
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1791316915-sharp-override
Closed

devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1791316915-sharp-override

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Dependabot security-update job on main failed (run, update npm_and_yarn in /. for braces, sharp, sprintf-js). The updater log shows:

| security_update_not_possible | "dependency-name": "sharp",
|                              | "latest-resolvable-version": "0.35.4",
|                              | "lowest-non-vulnerable-version": "0.35.5",
| security_update_not_possible | "dependency-name": "sprintf-js",
|                              | "latest-resolvable-version": "1.0.3",
|                              | "lowest-non-vulnerable-version": null,
| braces | security_update_not_found | "dependency-version": "3.0.3"

Change:

- sharp@<0.35.4: ^0.35.4
+ sharp@<0.35.5: ^0.35.5

The lockfile now resolves only sharp@0.35.5 and drops the 0.35.4 / libvips 1.3.3 @img/* entries. sharp 0.35.5 was published 2026-09-27, so it clears minimumReleaseAge (3 days). pnpm install --frozen-lockfile passes and wrangler --version still works.

Link to Devin session: https://app.devin.ai/sessions/085282fc37a04742acd59dcdf40e279c
Open in Devin Desktop: https://app.devin.ai/desktop/session/085282fc37a04742acd59dcdf40e279c?variant=devin


Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@changeset-bot

changeset-bot Bot commented Oct 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7edfcd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cla-bot cla-bot Bot added the cla-signed label Oct 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T20:04:26.611031Z 7edfcd4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TASTE.md review: compliant. This PR only changes the sharp dependency override (pnpm-workspace.yaml) and the lockfile, and touches none of the public SDK surface that TASTE.md T-1 through T-74 govern. 0 violations.

Written by Devin

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from e041692. Download artifacts from this workflow run.

JS SDK (e2b@2.54.1-devin-1791316915-sharp-override.0, with @e2b/dockerfile-utils@0.1.1-devin-1791316915-sharp-override.0):

npm install ./e2b-dockerfile-utils-0.1.1-devin-1791316915-sharp-override.0.tgz ./e2b-2.54.1-devin-1791316915-sharp-override.0.tgz

CLI (@e2b/cli@2.21.2-devin-1791316915-sharp-override.0):

npm install ./e2b-cli-2.21.2-devin-1791316915-sharp-override.0.tgz

Code Interpreter JS SDK (@e2b/code-interpreter@2.8.3-devin-1791316915-sharp-override.0):

npm install ./e2b-code-interpreter-2.8.3-devin-1791316915-sharp-override.0.tgz

Desktop JS SDK (@e2b/desktop@2.4.1-devin-1791316915-sharp-override.0):

npm install ./e2b-desktop-2.4.1-devin-1791316915-sharp-override.0.tgz

Python SDK (e2b==2.54.0+devin.1791316915.sharp.override, with e2b-dockerfile-utils==0.1.0+devin.1791316915.sharp.override):

pip install ./e2b_dockerfile_utils-0.1.0+devin.1791316915.sharp.override-py3-none-any.whl ./e2b-2.54.0+devin.1791316915.sharp.override-py3-none-any.whl

Code Interpreter Python SDK (e2b-code-interpreter==2.10.3+devin.1791316915.sharp.override):

pip install ./e2b_code_interpreter-2.10.3+devin.1791316915.sharp.override-py3-none-any.whl

Desktop Python SDK (e2b-desktop==2.6.1+devin.1791316915.sharp.override):

pip install ./e2b_desktop-2.6.1+devin.1791316915.sharp.override-py3-none-any.whl

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward dependency version bump.

What was reviewed: the pnpm-workspace.yaml override change (sharp pin raised from 0.35.4 to 0.35.5) and the corresponding pnpm-lock.yaml regeneration. Confirmed every removed line corresponds to the old 0.35.4 @ img/sharp-*/libvips-1.3.3 platform packages (hashes, cpu/os/libc metadata, dependency blocks) and that no unrelated packages, overrides, or source/config files were touched.

Extended reasoning...

Two-file change: a one-line override bump in pnpm-workspace.yaml and the matching lockfile regeneration in pnpm-lock.yaml, addressing a published sharp vulnerability (GHSA-wq5f-xc86-pv6w) per the PR description. No source code, build config, or test files are touched, so there's no injection/auth/data-exposure surface here. Verified via diff that every removed entry is an old 0.35.4/libvips-1.3.3 artifact and the 0.35.5 replacements were already present and unchanged, confirming lockfile consistency.

@mishushakov

Copy link
Copy Markdown
Member

this still a thing?

@devin-ai-integration

devin-ai-integration Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

@mishushakov Yes, this is still needed. On current main (b52cd30):

  • the override is still sharp@<0.35.4: ^0.35.4
  • pnpm-lock.yaml still resolves sharp@0.35.4, because miniflare@5.20260926.0-alpha (via wrangler@4.142.0) pins it exactly
  • GHSA-wq5f-xc86-pv6w (high) affects < 0.35.5

I merged the latest main into this branch (7ef78c0). The lockfile merged cleanly, and pnpm install --lockfile-only makes no further changes. The lockfile now resolves only sharp@0.35.5.

CI on the merged branch: 4 test jobs failed, but none of the failures involve sharp or the lockfile. The same sharp change was fully green before the merge.

  • Python SDK (staging ubuntu/windows): template builds returned BuildException: An internal error occurred. Please try again or contact support with the build ID. from the backend, and tests hit pytest timeouts. The Python SDK uses uv, not the pnpm lockfile.
  • Python SDK (production ubuntu): test_auto_resume_wakes_on_http_request failed with sandbox did not reach paused; last state was running, which is a sandbox timing issue.
  • Desktop JS SDK (deno): tests/client.test.ts timed out after 10s in the afterAll hook (server.close() on a local mock server). All 19 tests passed, and the node, bun and cloudflare desktop jobs passed.

Re-running the failed jobs should clear them.

Written by Devin

@mishushakov

Copy link
Copy Markdown
Member

this has been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant