Repository navigation
fix(deps): bump sharp override to ^0.35.5 (GHSA-wq5f-xc86-pv6w) - #1952
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Package ArtifactsBuilt from e041692. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.1-devin-1791316915-sharp-override.0.tgz ./e2b-2.54.1-devin-1791316915-sharp-override.0.tgzCLI ( npm install ./e2b-cli-2.21.2-devin-1791316915-sharp-override.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.8.3-devin-1791316915-sharp-override.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.4.1-devin-1791316915-sharp-override.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.0+devin.1791316915.sharp.override-py3-none-any.whl ./e2b-2.54.0+devin.1791316915.sharp.override-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.10.3+devin.1791316915.sharp.override-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.6.1+devin.1791316915.sharp.override-py3-none-any.whl |
There was a problem hiding this comment.
Looks good, straightforward dependency version bump.
What was reviewed: the pnpm-workspace.yaml override change (sharp pin raised from 0.35.4 to 0.35.5) and the corresponding pnpm-lock.yaml regeneration. Confirmed every removed line corresponds to the old 0.35.4 @ img/sharp-*/libvips-1.3.3 platform packages (hashes, cpu/os/libc metadata, dependency blocks) and that no unrelated packages, overrides, or source/config files were touched.
Extended reasoning...
Two-file change: a one-line override bump in pnpm-workspace.yaml and the matching lockfile regeneration in pnpm-lock.yaml, addressing a published sharp vulnerability (GHSA-wq5f-xc86-pv6w) per the PR description. No source code, build config, or test files are touched, so there's no injection/auth/data-exposure surface here. Verified via diff that every removed entry is an old 0.35.4/libvips-1.3.3 artifact and the 0.35.5 replacements were already present and unchanged, confirming lockfile consistency.
|
this still a thing? |
|
@mishushakov Yes, this is still needed. On current
I merged the latest CI on the merged branch: 4 test jobs failed, but none of the failures involve sharp or the lockfile. The same sharp change was fully green before the merge.
Re-running the failed jobs should clear them. |
|
this has been fixed? |
Summary
The Dependabot security-update job on
mainfailed (run, updatenpm_and_yarn in /. for braces, sharp, sprintf-js). The updater log shows:< 0.35.5.miniflare@5.20260926.0-alpha(viawrangler@4.142.0, js-sdk devDep) pinssharp: 0.35.4exactly, and our override wassharp@<0.35.4: ^0.35.4. Dependabot can't move a pinned transitive dep, and it doesn't editpnpm-workspace.yamloverrides. This is the same pattern as chore: bump pnpm security overrides for js-yaml, sharp, browserslist #1851.<= 3.0.3) and sprintf-js (GHSA-hp3w-g68c-fv3c,<= 1.1.3) have no patched version yet (3.0.3 and 1.1.3 are the latest releases), so no override is possible. The Dependabot job will keep failing on these until upstream ships fixes.Change:
The lockfile now resolves only
sharp@0.35.5and drops the 0.35.4 / libvips 1.3.3@img/*entries. sharp 0.35.5 was published 2026-09-27, so it clearsminimumReleaseAge(3 days).pnpm install --frozen-lockfilepasses andwrangler --versionstill works.Link to Devin session: https://app.devin.ai/sessions/085282fc37a04742acd59dcdf40e279c
Open in Devin Desktop: https://app.devin.ai/desktop/session/085282fc37a04742acd59dcdf40e279c?variant=devin