Get classloader resources - #6
Open
vitalii-honchar wants to merge 2 commits into
Open
Conversation
|
Guys, any ideas when pool-request can be merged? |
Collaborator
|
@WeaxMe @PhantomYdn I'll have a look today. |
dukeboard
requested changes
Feb 27, 2017
dukeboard
left a comment
dukeboard
left a comment
Owner
There was a problem hiding this comment.
Hi, thanks you for your contribution. I did a minor comment on the getAllResources method.
If this is not clear, I can also merge and mix layer, because this problem would only appear in Graph-like classloader organisation.
| public List<URL> getAllResources() { | ||
| List<URL> allResources = new ArrayList<URL>(); | ||
| for (FlexyClassLoader classLoader : subClassLoaders) { | ||
| allResources.addAll(classLoader.getAllResources()); |
Owner
There was a problem hiding this comment.
Here we have a risk of loop. FlexyClassLoader are linked using graph topology.
Therefore, the resolution should leverage a loop-breaking solution (usually with a map of already traversed FCL). This is the only potential problem is saw in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods for get classloader resources as List.