Repository navigation
chore(deps): bump dragonfly-hashring to 0.3.0 and remove the dead hashring git patch - #2142
Merged
Merged
Conversation
dragonfly-hashring 0.3.0 shares the node name across virtual nodes, so get_with_replicas no longer clones a String per returned virtual node. Key placement and the public API are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
requested review from
BraveY,
ClementMaH,
Fricounet,
Zephyrcf,
hhhhsdxxxx and
imeoer
November 5, 2026 15:44
gaius-qi
enabled auto-merge (squash)
November 5, 2026 15:45
The [patch.crates-io] entry points hashring at github.com/dragonflyoss/hashring-rs, which has been deleted, so cargo fails to fetch it and every CI job breaks. Drop the patch and go back to hashring 0.3.6 from crates.io, restoring Cargo.lock to its state before #2141. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
changed the title
yxxhero
approved these changes
Nov 5, 2026
CormickKneey
approved these changes
Nov 5, 2026
CormickKneey
left a comment
CormickKneey
left a comment
Contributor
There was a problem hiding this comment.
LGTM: bump dragonfly-hashring to 0.3.0 and drop the dead hashring-rs git patch so cargo can resolve hashring 0.3.6 from crates.io again. API/placement unchanged; restores CI.
CormickKneey
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dragonfly-hashringfrom 0.2.0 to 0.3.0.[patch.crates-io]entry added in chore: patch hashring to dragonflyoss/hashring-rs to avoid cloning the ring #2141. It pointshashringathttps://github.com/dragonflyoss/hashring-rs, which has been deleted.hashringgoes back to 0.3.6 from crates.io.Only
Cargo.tomland thedragonfly-hashringandhashringentries inCargo.lockchange.Related Issue
dragonflyoss/hashring#1, #2141
Motivation and Context
Fix CI. cargo cannot fetch the pinned
hashring-rsrevision anymore, so every CI job onmainfails with:hashring 0.3.6only comes in throughdragonfly-client-request1.7.3. Bumping that to 1.10.x, which depends ondragonfly-hashringinstead, is the follow-up.dragonfly-hashring 0.3.0. The release shares the node name across the virtual nodes of a node as
Arc<str>. As a result,get_with_replicasno longer clones aStringfor every returned virtual node (2.2x to 4.3x faster), and building a ring allocates once per node instead of 512 times. Key placement and the public API are unchanged, so the scheduler selected for a task stays the same.🤖 Generated with Claude Code