dotnet-watch tests failing

[dsplaisted]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build	Repository	Step Name	Console log	Pull Request
1601912	dotnet/sdk	Run FullFramework Tests	Log	#56353
1601840	dotnet/sdk	Run TestBuild Tests	Log	#56349
1600128	dotnet/sdk	🟣 Run TestBuild Tests	Log	#56330
1598948	dotnet/sdk	Run TestBuild Tests	Log	#56322
1596077	dotnet/sdk	🟣 Run FullFramework Tests	Log	#55377
1593505	dotnet/sdk	Run TestBuild Tests	Log	#56209
1589465	dotnet/sdk	Run TestBuild Tests	Log	#56209
1588817	dotnet/sdk	Run TestBuild Tests	Log	#56195
1588291	dotnet/sdk	Run TestBuild Tests	Log	#55739
1587882	dotnet/sdk	Run TestBuild Tests	Log	#55959
1587878	dotnet/sdk	🟣 Run TestBuild Tests	Log	#56172
1580263	dotnet/sdk	🟣 Run FullFramework Tests	Log	#56107
1577354	dotnet/sdk	Run TestBuild Tests	Log	#56082
1575901	dotnet/sdk	Run TestBuild Tests		#55714
1575906	dotnet/sdk	Run TestBuild Tests	Log	#55959
1575238	dotnet/sdk	Run TestBuild Tests	Log	#56050
1573450	dotnet/sdk	Run Tests in Helix	Log	#56011
1567458	dotnet/sdk	🟣 Run TestBuild Tests	Log	#55730
1569895	dotnet/sdk	🟣 Run TestBuild Tests	Log	#55918
1569544	dotnet/sdk	🟣 Run TestBuild Tests	Log	#55918
1568539	dotnet/sdk	🟣 Run TestBuild Tests	Log	#55939
1564170	dotnet/sdk	Run TestBuild Tests	Log	#55714
1561653	dotnet/sdk	Run TestBuild Tests	Log	#55714

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	5	23

[marcpopMSFT]

@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-41616-merge-58511284b77c40778a/dotnet-watch.Tests.dll.1/1/console.418de7ca.log?helixlogtype=result

[tmat]

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

[marcpopMSFT]

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

[tmat]

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

[Forgind]

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

[Forgind]

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.

[Forgind]

Ping @tmat
This is still a serious pain point, currently preventing MSBuild from merging their code flow to 9.0.2xx. I already clicked rerun twice. I pointed to a PR that I think is likely to blame.

[tmat]

Fixes targeting 9.0.3xx: #45999, #46141

[nagilson]

@tmat Thank you for making some PRs to try to remedy this -- we are still seeing this in 9.0.2xx, 9.0.1xx, and main, 10 preview 2. Do your changes need to be ported?