Repository navigation
Correct DevFlow schemas and specs to match existing runtime - #652
Merged
Merged
Conversation
Align WebView HTTP, streaming envelopes, and serialized DTOs with the recorded main baseline. Documentation and schemas only; no runtime or behavior changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8f1567da-8dcb-471a-a4e9-b5d96ead549c
Redth
approved these changes
Oct 9, 2026
Redth
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Schema/spec corrections only. No runtime, client, CLI, API, or behavior changes. All 12 changed files are under
docs/DevFlow/spec/.This is the bottom layer of the requested replacement stack for #651. The clean starting commit was exactly its recorded pre-implementation base,
64e8e90c6921e68cdb2747530b58dd528dd57578; all evidence below comes from that baseline, not the feature implementation.Existing-contract corrections
contexts, active only; metadata missing/non-null URL{webviews:[...]}includes inactive/not-ready registrations, nullable URL, index/automationId/isReady/active; IDs use existing registration aliasesDevFlowAgentService.Handlers.cs:195–243,2295–2316{success:false,error}400/404 responsesDevFlowAgentService.Handlers.cs:1853–1856,1965–2243,2319–2356/webview/networkremains the existing HTTP 200 native .NET network-store alias, not browser fetch/XHR or a new 501. WebView capture is native-first/CDP fallback; both screenshot routes return PNGDevFlowAgentService.Handlers.cs:2245–2293; Core screenshot:1983; Native:470t/l/c/m/e/s, preserve producer-defined level/source; headers contain arrays of valuesFileLogEntry.cs:9–14;NetworkRequestEntry.cs:59,63,147–162DevFlowAgentService.Handlers.cs:1382–1581SensorManager.cs:199–218,272–308;EssentialsAgentSupport.cs:696–798DevFlowAgentService.Handlers.cs:722–740,1583–1720;ProfilerContracts.cs:3–79DevFlowAgentService.Handlers.cs:768–868DevFlowAgentService.Handlers.cs:1061–1104; Client project and Driver type forwardsWhy the casing changes are corrections
Fps.X,Y,Z.[JsonPropertyName("l")]. HTTP/WS payloads already use that compact key.No hostKind, new
webview-<index>IDs, owner correlation, includeWebViewElements, compatibility removal, or lockstep-version implementation is included. Existing aliases (including ready/isReady) are preserved/documented.Validation
9 passed. A local, artifact-only probe exercised the pinned baseline handlers/serializers and recorded 37 HTTP/WS payloads; semantic validation parsed 32 spec documents, passed 67 payload/schema checks, and rejected 10 obsolete shapes.
git diff --checkpasses. No packages or tooling were added. CDP/native screenshot seams and controlled sensor values were used; no device/hardware coverage is claimed.Separate audit findings
This coherent correction slice is not a claim of complete protocol conformance. Verified follow-ups are recorded separately: agent-status fields, UI query/tree options and screenshot aliases/defaults, device/sensor-list shapes and enum casing, remaining general error schemas, and distributed debug/setup docs claiming a nonexistent Blazor JS initializer. The detailed 30-row evidence matrix and payload/probe artifacts are retained in the owning session rather than adding tracking Markdown or broader onboarding rewrites to this PR.