Skip to content

Cleanup: package alignment, skill fix, and Azure AI Search optional step - #595

Closed
ShiyunXu wants to merge 3 commits into
dotnet-presentations:mainfrom
ShiyunXu:copilot/cleanup-package-alignment
Closed

ShiyunXu wants to merge 3 commits into
dotnet-presentations:mainfrom
ShiyunXu:copilot/cleanup-package-alignment

Conversation

@ShiyunXu

Copy link
Copy Markdown
Contributor

Summary

Three small cleanups on one branch:

  1. Fix workshop-testing skill quirk — the known-quirks list said the Part 6 snapshot uses namespace MyMcpServer.Tools;; it actually uses namespace ContosoOrdersMcpServer.Tools;.
  2. Align Azure.AI.OpenAI package versions — bump ChatApp, RagChatApp, AgentApp, and StoreApp from 2.1.0 to 2.3.0-beta.2 so all snapshots match GenAiLab.Web (Part 11). The dotnet-build CI matrix validates the build.
  3. Restore the optional Azure AI Search walkthrough — the step-by-step managed-vector-store instructions (originally in the pre-renumber Part 6 - Deployment README) were removed in docs: reorder and renumber workshop parts #553, leaving only a "scaffold and diff" note. This adds them back as an optional applied section in Part 10 - Choosing Providers and Services (where provider/service selection happens, immediately before deployment), with a cross-link from Part 11's "Optional: using a managed vector store" section. Includes the scaffold escape hatch for attendees without their Part 4 project, the Basic-tier requirement, the Endpoint=...;Key=... connection-string format for the azd provision prompt, and a mandatory teardown warning (AI Search bills per service hour when idle).

Needs verification

The --vector-store azureaisearch template flag and the azd azureAISearch infrastructure-parameter prompt are restored from the pre-#553 content and should be validated against the current Microsoft.Extensions.AI.Templates aichatweb template in a workshop-testing run before the next delivery.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot AI added 3 commits August 25, 2026 06:19
GenAiLab.Web (Part 11) already pins 2.3.0-beta.2; bump ChatApp,
RagChatApp, AgentApp, eShopLite Store/Products, and the Part 3
checkpoint verify projects from 2.1.0 so every snapshot uses the
same version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ContosoOrdersTools.cs uses namespace ContosoOrdersMcpServer.Tools,
not MyMcpServer.Tools.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore a step-by-step managed vector store path (originally in the
pre-renumber Part 6 - Deployment README, removed in the July 2026
restructure) as an optional applied section in Part 10, where provider
and service selection happens. Part 11's 'Optional: using a managed
vector store' section now links back to it for provisioning steps.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jongalloway

Copy link
Copy Markdown
Contributor

Thank you for putting this together, especially for restoring attention to the managed vector-store path and for calling out the teardown cost. I also appreciate that the PR identified the workshop-testing namespace issue and tried to make package versions more consistent across the snapshots.

I re-evaluated this against the current workshop, the latest Microsoft.Extensions.AI.Templates package, current package releases, and current Azure AI Search documentation. I also merged the current main into this branch locally and ran the full nine-target .NET 10 build matrix. All nine targets build successfully, so the reason for closing is not a compile failure. The remaining concerns are about the package policy and attendee workflow:

  • The namespace correction has already been delivered independently in Fix Part 6 namespace in workshop-testing skill known quirks #596, so that part of this PR is now redundant.
  • The Azure.AI.OpenAI change moves seven projects from stable 2.1.0 to 2.3.0-beta.2 only to align version numbers. 2.1.0 is still the latest stable release, while the preview line has advanced to 2.9.0-beta.1. Taking an older beta now would add prerelease risk without providing a required feature or current-version benefit.
  • The Azure AI Search walkthrough says vector search requires Basic or higher. Current Microsoft documentation says vector search is available on all tiers, including Free. Free has capacity and identity limitations, but vector support itself is not restricted to Basic.
  • The walkthrough presents manual portal provisioning, an admin key, and an Endpoint=...;Key=... connection string as the expected deployment path. The current Aspire template generates builder.AddAzureSearch("search"), allowing Aspire and azd to provision the resource and configure identity-based access. That should be the primary workshop path; manual connection to an existing service can be documented as an alternative.
  • The scaffold-and-diff step does not give attendees the package migration needed to convert their existing Qdrant project. It needs explicit removal of the Qdrant AppHost/client packages, addition of the Azure Search hosting/client/vector-store packages, and matching AppHost and web registration changes.
  • Choose providers and prepare Azure AI Search deployment #594 covers the same Part 10/Part 11 workflow and includes the actual snapshot migration, so maintaining both PRs would leave us reconciling two competing versions of the same instructions.

I am going to close this PR rather than ask you to rework overlapping changes. I plan to carry the useful intent forward while updating #594: preserve the Qdrant fallback and teardown warning, use the current Aspire-managed Azure Search flow, update the tier guidance, include complete package and registration steps, and keep the README synchronized with the Part 11 snapshot.

Thanks again for the thoughtful contribution and for surfacing areas of the workshop that needed another pass.

@jongalloway jongalloway closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants