-
-
Notifications
You must be signed in to change notification settings - Fork 13
chore: adopt Ultracite, Oxlint, and TypeScript 7 #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f17c3b1
chore: adopt Ultracite and TypeScript 7 toolchain
Geczy 1970dbb
chore: lint Supabase Edge Functions with Deno config
Geczy 857b5cd
chore: ratchet Ultracite quality baseline
Geczy dc32c4f
fix: resolve frontend quality and security checks
Geczy e4f5d8f
fix: normalize oxlint plugin policy order
Geczy 3ae54e0
fix: stabilize resolved oxlint policy
Geczy 7e27ed4
fix: resolve frontend CodeQL findings
Geczy ba815f6
fix: harden frontend navigation boundaries
Geczy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/knip@6/schema.json", | ||
| "ignore": ["public/styles/obs-compat.css"], | ||
| "ignore": [".agents/**", "public/styles/obs-compat.css"], | ||
| "ignoreBinaries": ["doppler"], | ||
| "entry": ["scripts/**/*.{ts,mjs}"] | ||
| "ignoreDependencies": ["npm"], | ||
| "entry": ["scripts/**/*.{ts,mjs}", "supabase/functions/**/*.ts"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| import "./.next/dev/types/routes.d.ts"; | ||
| import "./.next/types/routes.d.ts"; | ||
| import "./.next/types/root-params.d.ts"; | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/pages/api-reference/config/typescript for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { defineConfig } from 'oxfmt' | ||
| import ultracite from 'ultracite/oxfmt' | ||
|
|
||
| export default defineConfig({ | ||
| ...ultracite, | ||
| ignorePatterns: [ | ||
| ...(ultracite.ignorePatterns ?? []), | ||
| '.agents/**', | ||
| '.claude/**', | ||
| '.cursor/**', | ||
| '.impeccable/**', | ||
| 'supabase/.temp/**', | ||
| ], | ||
| jsxSingleQuote: true, | ||
| printWidth: 100, | ||
| semi: false, | ||
| singleQuote: true, | ||
| trailingComma: 'all', | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { defineConfig } from 'oxlint' | ||
| import antiSlop from 'ultracite/oxlint/anti-slop' | ||
| import core from 'ultracite/oxlint/core' | ||
| import { jsPluginSettings, selectJsPlugins } from 'ultracite/oxlint/js-plugins' | ||
| import next from 'ultracite/oxlint/next' | ||
| import nextJsPlugins from 'ultracite/oxlint/next/js-plugins' | ||
| import react from 'ultracite/oxlint/react' | ||
| import vitest from 'ultracite/oxlint/vitest' | ||
|
|
||
| // eslint-plugin-github currently pulls typescript-eslint, whose parser crashes | ||
| // under TypeScript 7. Keep SonarJS and React Doctor active until that stack is | ||
| // TS7-compatible again. | ||
| const jsPlugins = selectJsPlugins(['sonarjs', 'react-doctor']) | ||
|
|
||
| export default defineConfig({ | ||
| extends: [core, react, next, vitest, antiSlop, jsPlugins, nextJsPlugins], | ||
| ignorePatterns: [ | ||
| ...(core.ignorePatterns ?? []), | ||
| '.agents/**', | ||
| '.claude/**', | ||
| '.cursor/**', | ||
| '.impeccable/**', | ||
| 'supabase/.temp/**', | ||
| ], | ||
| jsPlugins: jsPlugins.jsPlugins ?? [], | ||
| options: { | ||
| reportUnusedDisableDirectives: 'error', | ||
| respectEslintDisableDirectives: true, | ||
| typeAware: true, | ||
| typeCheck: true, | ||
| }, | ||
| rules: { | ||
| 'no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| argsIgnorePattern: '^_', | ||
| caughtErrorsIgnorePattern: '^_', | ||
| destructuredArrayIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| }, | ||
| ], | ||
| 'typescript/no-explicit-any': 'error', | ||
| }, | ||
| settings: jsPluginSettings, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { defineConfig } from 'oxlint' | ||
| import antiSlop from 'ultracite/oxlint/anti-slop' | ||
| import core from 'ultracite/oxlint/core' | ||
| import { jsPluginSettings, selectJsPlugins } from 'ultracite/oxlint/js-plugins' | ||
| import next from 'ultracite/oxlint/next' | ||
| import nextJsPlugins from 'ultracite/oxlint/next/js-plugins' | ||
| import react from 'ultracite/oxlint/react' | ||
| import vitest from 'ultracite/oxlint/vitest' | ||
|
|
||
| const jsPlugins = selectJsPlugins(['sonarjs', 'react-doctor']) | ||
|
|
||
| // Supabase Edge Functions run in Deno rather than the app's Node/tsgo runtime. | ||
| // Keep the same Ultracite policy but skip only incompatible type analysis. | ||
| export default defineConfig({ | ||
| env: { | ||
| worker: true, | ||
| }, | ||
| extends: [core, react, next, vitest, antiSlop, jsPlugins, nextJsPlugins], | ||
| globals: { | ||
| Deno: 'readonly', | ||
| }, | ||
| ignorePatterns: [ | ||
| ...(core.ignorePatterns ?? []), | ||
| '.agents/**', | ||
| '.claude/**', | ||
| '.cursor/**', | ||
| '.impeccable/**', | ||
| 'supabase/.temp/**', | ||
| ], | ||
| jsPlugins: jsPlugins.jsPlugins ?? [], | ||
| options: { | ||
| reportUnusedDisableDirectives: 'error', | ||
| respectEslintDisableDirectives: true, | ||
| typeAware: false, | ||
| typeCheck: false, | ||
| }, | ||
| rules: { | ||
| 'no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| argsIgnorePattern: '^_', | ||
| caughtErrorsIgnorePattern: '^_', | ||
| destructuredArrayIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| }, | ||
| ], | ||
| 'typescript/no-explicit-any': 'error', | ||
| }, | ||
| settings: jsPluginSettings, | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.