Repository navigation
tests/integration: Make the tests runnable on SELinux enabled daemon - #3367
Merged
Merged
Conversation
Signed-off-by: Ricardo Branco <rbranco@suse.de>
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes correctly address SELinux permission failures without altering library behavior.
Pull request overview
Enables volume integration tests to run against SELinux-enabled Docker daemons.
Changes:
- Applies shared SELinux relabeling to model-level bind mounts.
- Disables SELinux labeling where mount syntax cannot request relabeling.
File summaries
| File | Description |
|---|---|
tests/integration/models_containers_test.py |
Adds :z to shared bind mounts. |
tests/integration/api_container_test.py |
Adds SELinux-compatible security options to volume tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the tests runnable on SELinux enabled daemon.
Otherwise I get failures like these: https://openqa.opensuse.org/tests/5393787/file/python_docker-integration.txt