Repository navigation
Expect DNSKEY public keys as their bytes, for dns_erlang 6 - #54
Draft
NelsonVides wants to merge 3 commits into
Draft
NelsonVides wants to merge 3 commits into
NelsonVides wants to merge 3 commits into
Conversation
dns_erlang 6 keeps a DNSKEY's and CDNSKEY's public_key as the RDATA's key field, where 5.x decoded an RSA key from the wire into [E, M]. The expected CDNSKEY of minimal-dnssec.com built its key as [E, M] to match, through decode_dnskey_public_key/1, which now returns the key field's bytes. compute_base64_key/1, which turned [E, M] back into base64 and which nothing called, is gone.
With `~> 6.0` and no 6.0.0 on hex, rebar3 kept building from the 5.0.18 in rebar.lock without complaint, so nothing here ran against dns_erlang 6. Pin the commit dns_erlang's main is at instead: by ref, because elvis's no_branch_deps rule rejects a branch. Once 6.0.0 is on hex, the dependency goes back to `~> 6.0` and the lock follows with `rebar3 upgrade dns_erlang`.
dns_erlang's main moved on to 60db43f, with #198 (zone file owners) and #199 (signing only RRsets the signer's zone can hold). dnstest calls neither dns_sec nor the zone file decoder, so nothing here changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns_erlang 6 keeps the
public_keyof a DNSKEY or CDNSKEY as the key field of its RDATA, as bytes (dnsimple/dns_erlang#184). 5.x decoded an RSA key from the wire into[E, M], and the expected CDNSKEY ofminimal-dnssec.combuilt its key the same way throughdnstest_harness:decode_dnskey_public_key/1, so it no longer matches what a server on dns_erlang 6 answers.decode_dnskey_public_key/1now returns the key field's bytes.compute_base64_key/1, which turned[E, M]back into base64, is gone. It was exported, but nothing called it, here or in erldns and erldnsimple.This stays a draft until dns_erlang 6.0.0 is on hex. Until then,
rebar.configtakes dns_erlang from itsmain, so CI runs against dns_erlang 6. It pins the commitmainis at (60db43f) rather than the branch, because elvis'sno_branch_depsrule rejects branch dependencies. Once the release is out, the dependency goes back to~> 6.0and the lock follows withrebar3 upgrade dns_erlang.erldnsimple follows
mainhere and requiresdns_erlang ~> 5.1, so it has to move to dns_erlang 6 in the same change that moves itsmix.lockpast this merge. erldns pins this repo by commit in its test profile, and its move to dns_erlang 6 should pin this branch's commit.