Skip to content

Expect no out-of-zone addresses in the additional section of dnssec_ns - #53

Merged
NelsonVides merged 1 commit into
mainfrom
fix/additional-in-zone
Nov 16, 2026
Merged

NelsonVides merged 1 commit into
mainfrom
fix/additional-in-zone

Conversation

@NelsonVides

Copy link
Copy Markdown
Contributor

erldns is changing its additional section processing: it now looks up the addresses of NS and MX targets only at or below the apex of the zone that answers, where it used to take them from any zone it had loaded. Resolvers drop the records of a target outside the apex as out of bailiwick (RFC 5452 §6), and on a server that hosts zones for many parties they can come from a zone that isn't in the same hands as the one answering.

dnssec_ns pinned the old behaviour: minimal-dnssec.com is served by ns1.example.com and ns2.example.com, and the spec expected example.com's A and AAAA records for them in the additional section of the NS answer. It now expects none. No other spec changes: every other definition passes against the erldns branch as it is, and none of the PowerDNS regression tests these specs descend from expects addresses from outside the answering zone.

The erldns change is on fix/additional-in-zone in dnsimple/erldns and pins this branch by commit. erldnsimple follows main here, locked in mix.lock, and its integration suite runs dnssec_ns, so the lock should move in the erldnsimple PR that bumps to the released erldns.

erldns now adds to the additional section the addresses of the NS and
MX targets at or below the apex of the zone that answers, and no
others. The NS RRset of minimal-dnssec.com names ns1.example.com and
ns2.example.com, which belong to example.com, another zone of the
corpus, so their A and AAAA records no longer follow the answer.

erldns's dnstest_SUITE passes against this definition with that change.
@NelsonVides NelsonVides added the bug Code defect or incorrect behavior label Nov 16, 2026
@NelsonVides NelsonVides self-assigned this Nov 16, 2026
@NelsonVides
NelsonVides merged commit d5c3670 into main Nov 16, 2026
2 checks passed
@NelsonVides
NelsonVides deleted the fix/additional-in-zone branch November 16, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Code defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant