Repository navigation
Expect no out-of-zone addresses in the additional section of dnssec_ns - #53
Merged
Merged
Conversation
erldns now adds to the additional section the addresses of the NS and MX targets at or below the apex of the zone that answers, and no others. The NS RRset of minimal-dnssec.com names ns1.example.com and ns2.example.com, which belong to example.com, another zone of the corpus, so their A and AAAA records no longer follow the answer. erldns's dnstest_SUITE passes against this definition with that change.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
erldns is changing its additional section processing: it now looks up the addresses of NS and MX targets only at or below the apex of the zone that answers, where it used to take them from any zone it had loaded. Resolvers drop the records of a target outside the apex as out of bailiwick (RFC 5452 §6), and on a server that hosts zones for many parties they can come from a zone that isn't in the same hands as the one answering.
dnssec_nspinned the old behaviour:minimal-dnssec.comis served byns1.example.comandns2.example.com, and the spec expectedexample.com's A and AAAA records for them in the additional section of the NS answer. It now expects none. No other spec changes: every other definition passes against the erldns branch as it is, and none of the PowerDNS regression tests these specs descend from expects addresses from outside the answering zone.The erldns change is on
fix/additional-in-zonein dnsimple/erldns and pins this branch by commit. erldnsimple followsmainhere, locked inmix.lock, and its integration suite runsdnssec_ns, so the lock should move in the erldnsimple PR that bumps to the released erldns.