Repository navigation
Release 6.0.0 - #200
Draft
NelsonVides wants to merge 1 commit into
Draft
Release 6.0.0#200NelsonVides wants to merge 1 commit into
NelsonVides wants to merge 1 commit into
Conversation
Name the unreleased changes v6.0.0, with the five that need code changed first under Changed, a migration guide for them, and the base_dir option under Removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names the unreleased changes v6.0.0. Only CHANGELOG.md changes: the entries are as they were merged, with the API changes that need code changed moved first under Changed, a migration guide after them, as 5.0.0 had, and the
base_diroption under a new Removed section. A one-line intro at the top of the section points to the guide.The breaking changes are the
dnssecmodule's new namedns_sec, DNSKEY and CDNSKEY keys held as their RDATA bytes, the JSON form of RSA and DSA keys, RSA and DSA private keys as bytes, and$INCLUDEkept to the zone file's directory. The rest refuses zone files, JSON and RRSIGs that 5.x took, and needs no code change.Checks on the migration guide's snippets:
dns_secexports every function v5.2.0'sdnssecdid, under the same name and arity, plusdnskey_public_key/2.dns_json:to_map/1. Each gives exactly the key 6.0'sto_map/1writes for the same key, and the converted map loads withfrom_map/1. 6.0 refuses the unconverted 5.x maps withinvalid_record.rsa_numbers/1gives back[E, M]for an exponent in RFC 3110's short form and in its long form.{badarg, number_not_bytes}when signing, and sign once converted withbinary:encode_unsigned/1.erldns's
chore/dns-erlang-6branch, pinned to this release's code (60db43f), passes itsmake test: format, lint, xref, dialyzer, ex_doc and all 445 tests.rebar3 ex_docandrebar3 hex buildpass here.Left for 6.x, as they change no API: the signing inception's clock-skew margin (S5 of #169), NSEC and NSEC3 generation (#170), and validity periods in serial number arithmetic.
After merge and a green CI on main, tag the merge commit
v6.0.0; the release workflow publishes to Hex.