Repository navigation
Refuse no-default-alpn without alpn in zone files and JSON - #195
Merged
Merged
Conversation
RFC 9460 section 7.1.1 has an RR with no-default-alpn carry alpn too, or it is not self-consistent, and section 2.4.3 has zone-file implementations enforce that. BIND refuses such an RR, by name or as key2; dns_erlang loaded it. Zone files and JSON now refuse it, with the check for mandatory's keys. The wire decoder still takes it: a client is to reject the RR rather than the message, and PowerDNS loads one, in the test zone example.com.zone comes from, whose line has alpn=h3 added now. The zone writer property's parameters get an alpn with no-default-alpn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9460 §7.1.1: "When "no-default-alpn" is specified in an RR, "alpn" must also be specified in order for the RR to be "self-consistent"", and §2.4.3 has zone-file implementations enforce self-consistency (SHOULD) and clients reject an RR that is not (MUST). BIND 9.20.30's
named-checkzonerefuses one, spelledno-default-alpnorkey2; dns_erlang loaded it.no-default-alpnorkey2withoutalpn{no_default_alpn_without_alpn, [1]}"no-default-alpn": nullwithout"alpn"{svcb_mandatory_validation_error, {no_default_alpn_without_alpn, [1]}}alpnThe check sits with the one for mandatory's keys, under its error for JSON, but only for zone files and JSON. The wire decoder still takes such an RR: the RFC has a client reject the RR rather than the message, and refusing it would fail every message that carries one, from a server that serves one. PowerDNS loads one: its
example.comtest zone, whichtest/dns_zone_SUITE_data/example.com.zonecomes from, hasbar.svcb IN SVCB 5 . port="8004" no-default-alpn .... That line hasalpn=h3in it now, with a comment saying so.Tests:
parse_svcb_with_no_default_alpnreads it withalpn, refuses it without by name, by number, in HTTPS and when mandatory names it, has JSON refuse it, and the wire decoder take it. Taking out the refusal, or refusing on the wire too, makes it fail. The zone writer property's parameters hadno-default-alpnwithoutalpnat times, and get analpnwith it now.