You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: update svgr to 0.50.3 so a nested group's fade is not drawn from a stale layer - #266
On the CPU backend, a group inside an isolated group (opacity below 1, a clip, a mask or a filter) kept the opacity it had the first time the outer group was drawn. A fade of the inner group did not fade in render, strip or frame with several times, because those share one layer cache across frames.
The cause was in usvgr: the layer cache key left out the opacity and blend mode of nested groups, although they are part of the cached pixels.
Fix
Updates svgr and usvgr from 0.50.2 to 0.50.3, which hashes a nested group's opacity and blend mode in the key (dmtrKovalenko/svgr#25). That release contains no other change.
Checks
cargo test -p fframes passes.
just e2e cpu passes: every example frame matches its snapshot within the tolerance.
The regression test for the issue's case is in svgr (nested_group_opacity_and_blend_mode_change_cached_layer). This PR adds no test in fframes.
Summary by CodeRabbit
Chores
Updated the tooling used for SVG graphics to a newer patch release. No changes to user-facing functionality are included in this update.
This updates the SVG rendering dependencies to a patch release that fixes stale cached pixels when a nested group's opacity or blend mode changes. No merge-blocking risk is identified, and the reported tests and snapshot checks pass.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the change: it updates svgr to 0.50.3 and fixes a stale cached layer for a nested group's fade. The raw summary confirms the svgr and usvgr bump from 0.50.2 to 0.50.3. The PR objective…
Linked Issues check
The only directly linked issue, #264, is closed and marked as historical context only. No active directly linked targets remain, so no linked-issue coding requirements apply. The PR description and su…
Out of Scope Changes check
The reviewed change is a two-line version bump in Cargo.toml. It moves the workspace dependencies svgr and usvgr from 0.50.2 to 0.50.3. The PR description states that the 0.50.3 release is the fix for…
Full details: Title check
Explanation
The title names the change: it updates svgr to 0.50.3 and fixes a stale cached layer for a nested group's fade. The raw summary confirms the svgr and usvgr bump from 0.50.2 to 0.50.3. The PR objectives describe the layer-cache key fix for nested group opacity and blend mode, which matches the title's stated intent. The title is specific and relevant, though the summary mentions only the version bump in Cargo.toml, so the fix itself rests on the upstream svgr release.
Full details: Linked Issues check
Explanation
The only directly linked issue, #264, is closed and marked as historical context only. No active directly linked targets remain, so no linked-issue coding requirements apply. The PR description and summary also state this. No requirement from #264 was turned into a PR objective.
Full details: Out of Scope Changes check
Explanation
The reviewed change is a two-line version bump in Cargo.toml. It moves the workspace dependencies svgr and usvgr from 0.50.2 to 0.50.3. The PR description states that the 0.50.3 release is the fix for the nested group opacity and blend mode hashing problem described in #264. The bump is therefore the mechanism that implements the referenced fix, not an unrelated change. Cargo.lock is excluded from review (ignored by the !**/*.lock rule), so the lockfile update was not inspected. This does not change the assessment because the lockfile is a derived artifact of the same version bump. The regression test is in the svgr repository, not in this PR, which is consistent with the PR description.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 672cc740-f2aa-486b-a2bf-9a00a9bfb665
Commits
Reviewing files that changed from the base of the PR and between 7cf6712 and d4bf0e2.
Files ignored due to path filters: 1
Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
Cargo.toml
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #264.
Problem
On the CPU backend, a group inside an isolated group (opacity below 1, a clip, a mask or a filter) kept the opacity it had the first time the outer group was drawn. A fade of the inner group did not fade in
render,striporframewith several times, because those share one layer cache across frames.The cause was in
usvgr: the layer cache key left out the opacity and blend mode of nested groups, although they are part of the cached pixels.Fix
Updates
svgrandusvgrfrom 0.50.2 to 0.50.3, which hashes a nested group's opacity and blend mode in the key (dmtrKovalenko/svgr#25). That release contains no other change.Checks
cargo test -p fframespasses.just e2e cpupasses: every example frame matches its snapshot within the tolerance.nested_group_opacity_and_blend_mode_change_cached_layer). This PR adds no test in fframes.Summary by CodeRabbit