Repository navigation
feat: give four rows and twenty columns back to the data - #28
Merged
Merged
Conversation
Items 4 and 3 of the TUI review. On an 80x24 terminal, chrome took 61% of the screen: three rows of header and three of status bar to show two lines of text, plus 25 of 80 columns for eight labels that never change. Header and status bar are one borderless row each. The header now claims width for the security badges first — `[READ-ONLY]` used to be on the right of a fixed split and was the first thing an 80-column terminal cut off — and degrades the identity text instead, dropping the app name before the host. The sidebar collapses below 100 columns to a rail of tab numbers, three columns wide. The numbers are not decoration: 1-8 now jump straight to a tab, which is what makes the collapsed form usable rather than merely present. Together that turns a 53x14 content area at 80x24 into 77x18 — from 39% of the screen to 72%. Chain and action are readable there now instead of `forwar` and `acce`. Icon alignment is measured rather than assumed. `⚙` and `🛡` occupy one column while the rest occupy two, and the old list compensated with hand-placed trailing spaces — correctly except for `📡`, which had one too many and pushed its row a column right. Icons are now bare glyphs padded to a measured two columns with `unicode-width`, the same crate ratatui uses for layout, pinned to the version already in the tree. The alignment test measures the column a label lands in, not the char index of a concatenated row: a wide emoji occupies one cell and leaves the next holding an empty string, so string offsets measure neither width nor position. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items 4 and 3 of the TUI review. On an 80×24 terminal, chrome took 61% of the screen: three rows of header and three of status bar to show two lines of text, plus 25 of 80 columns for eight labels that never change.
After
Content area at 80×24 goes from 53×14 to 77×18 — 39% of the screen to 72%.
Header and status bar
One borderless row each. The header claims width for the security badges first:
[READ-ONLY]used to sit on the right of a fixed split and was the first thing an 80-column terminal cut off. Identity text degrades instead, dropping the app name before the host.Collapsible sidebar
Below 100 columns it becomes a rail of tab numbers, three columns wide. The numbers are not decoration —
1–8now jump straight to a tab, which is what makes the collapsed form usable rather than merely present.Icon alignment, measured
⚙and🛡occupy one column while the rest occupy two. The old list compensated with hand-placed trailing spaces — correctly, except📡had one too many and pushed its row a column right. Icons are now bare glyphs padded to a measured two columns usingunicode-width, the same crate ratatui uses for layout, pinned to the version already in the tree (no new version enters the dependency graph).Worth recording how the test measures, because two earlier attempts measured the wrong thing: it finds the column a label lands in, not the char index of a concatenated row. A wide emoji occupies one cell and leaves the next holding an empty string, so string offsets measure neither width nor position. Verified by reverting the padding —
[6, 7, 7, 7, 7, 6, 7, 7].Testing
83 tests, up from 78. Coverage for chrome height, the sidebar collapsing at the threshold, the
READ-ONLYbadge surviving every width from 80 up, label alignment, and the number keys mapping onto tabs.Still open
80 columns is better but not solved:
Src. Aandforwarare still clipped. Dropping whole columns by priority — item 2 — is the last piece.🤖 Generated with Claude Code