add support for malformed tests#1918
Draft
yisraelU wants to merge 3 commits into
Draft
Conversation
|
|
…a.js Use .attempt instead of .attemptNarrow[IntendedShortCircuit] so server exceptions during decode of malformed input are treated as valid rejections. Add index suffixes to parameterized test IDs to prevent name collisions. Skip malformed request test generation entirely on Scala.js — Timestamp.parseDateTime uses unchecked charAt that produces fatal UndefinedBehaviorError on JS. These tests still run on JVM.
yisraelU
force-pushed
the
MalformedTestCompliance
branch
from
48288ff to
a4a9e6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)