refactor: cleanup & general refactor - #91
Open
NotSugden wants to merge 6 commits into
Open
Conversation
NotSugden
force-pushed
the
refactor-clean-code
branch
from
September 18, 2020 17:48
be19d5a to
14a915f
Compare
NotSugden
force-pushed
the
refactor-clean-code
branch
from
September 18, 2020 18:49
4a86a02 to
14a915f
Compare
Author
|
i suck at git - apologies for that |
NotSugden
marked this pull request as draft
March 10, 2021 21:05
NotSugden
force-pushed
the
refactor-clean-code
branch
from
March 10, 2021 21:08
f2662df to
3fd3c6c
Compare
NotSugden
marked this pull request as ready for review
March 10, 2021 21:11
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference: this pr is apart of the chain of prs requested from #89 (comment)
This PR is a general refactor to cleanup some code, return correct values as outlined by the documentation (see previous PR #90)
This PR also adds (back?) the custom Error class to handle errors
important note: some of the documentation around the diff changes will be incorrect, #90 has these changes and should be merged before this