Skip to content

Fix profiling: use --verbosity 8 instead of 10#8977

Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:profiling-verbosity
Open

Fix profiling: use --verbosity 8 instead of 10#8977
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:profiling-verbosity

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

Verbosity 10 triggers per-step SSA output via SSA_stept::output, which calls format_rec and accounts for ~16% of the profile. This distorts the results. Verbosity 8 still captures Runtime statistics without the per-step output.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Verbosity 10 triggers per-step SSA output via SSA_stept::output,
which calls format_rec and accounts for ~16% of the profile. This
distorts the results. Verbosity 8 still captures Runtime statistics
without the per-step output.

Co-authored-by: Kiro <[email protected]>
@tautschnig tautschnig self-assigned this Apr 27, 2026
Copilot AI review requested due to automatic review settings April 27, 2026 10:44
@tautschnig tautschnig requested a review from a team as a code owner April 27, 2026 10:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adjusts the profiling runner to avoid distorting profiling results by preventing CBMC from emitting expensive per-step SSA output.

Changes:

  • Lower CBMC verbosity from 10 to 8 in the profiling runner to keep runtime statistics without per-step SSA output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if not any(a in cmd for a in ("--dimacs", "--smt2", "--show-vcc")):
cmd += ["--dimacs", "--outfile", "/dev/null"]
cmd += ["--verbosity", "10"]
cmd += ["--verbosity", "8"]
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a new implicit tuning parameter (verbosity level) as a magic number. Consider defining a named constant (e.g., CBMC_PROFILE_VERBOSITY = 8) or making it configurable via a CLI flag/env var for the runner, so future profiling runs can adjust verbosity without editing code.

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.50%. Comparing base (b32074b) to head (148f812).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8977   +/-   ##
========================================
  Coverage    80.50%   80.50%           
========================================
  Files         1704     1704           
  Lines       188778   188778           
  Branches        73       73           
========================================
+ Hits        151975   151978    +3     
+ Misses       36803    36800    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants