#2271: fix pgadmin installation on linux - #2388
Conversation
Coverage Report for CI Build 33490596893Coverage increased (+0.006%) to 73.619%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions90 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
4c47ff0 to
eddf18b
Compare
There was a problem hiding this comment.
I would also suggest updating the current pgAdmin URL updater, as it does not support Linux versions yet. The pgAdmin download repository provides Linux packages (APT and YUM) in addition to the existing artifacts. You can find more information here: pgAdmin download repository.
Thanks, I looked into this. The pgAdmin Linux repository differs from the Windows artifacts: the APT and YUM packages are distribution-specific (e.g. Noble, Bookworm/Trixie, Fedora/RHEL), while the current URL updater model only distinguishes OS and architecture and has no Linux distribution dimension. Because of that, adding a single LINUX URL would potentially generate incorrect metadata for other distributions. The runtime installation in this PR intentionally uses the native package manager/repository instead. I think proper Linux support in PgAdminUrlUpdater would require distro-aware URL metadata (URL metadata that knows whether a Linux artifact is for Ubuntu, Debian, Fedora, RHEL, openSUSE, etc) or separate handling for package repositories. |
eddf18b to
5a51554
Compare
This PR fixes #2271
Implemented changes:
ide install pgadminon Linux when pgAdmin is installed via native packages.Testing instructions
Please add concise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
./build-local-dev.shide install pgadminChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidocChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet