Skip to content

2250: uninstall commands from package manager test fix - #2379

Open
JoelAdbu wants to merge 13 commits into
devonfw:mainfrom
JoelAdbu:fix/2250-uninstall-commands-from-package-manager-test-fix
Open

2250: uninstall commands from package manager test fix#2379
JoelAdbu wants to merge 13 commits into
devonfw:mainfrom
JoelAdbu:fix/2250-uninstall-commands-from-package-manager-test-fix

Conversation

@JoelAdbu

@JoelAdbu JoelAdbu commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR improves test coverage for GlobalToolCommandletTest as suggest in: #2258 (comment)

Implemented changes:

  • added new test method to test uninstall feature via package manager
  • added new test class to capture uninstall commands before execution and allow assertions without executing the actual commands

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run:
mvn clean test

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Aug 27, 2026
@JoelAdbu JoelAdbu moved this from 🆕 New to 🏗 In progress in IDEasy board Aug 27, 2026
@coveralls

coveralls commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 33054256369

Coverage increased (+0.2%) to 73.908%

Details

  • Coverage increased (+0.2%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 1 91.86%

Coverage Stats

Coverage Status
Relevant Lines: 18221
Covered Lines: 14072
Line Coverage: 77.23%
Relevant Branches: 8074
Covered Branches: 5362
Branch Coverage: 66.41%
Branches in Coverage %: Yes
Coverage Strength: 3.3 hits per line

💛 - Coveralls

@JoelAdbu JoelAdbu added linux specific for linux OS (debian, ubunutu, suse, etc.) uninstall uninstall tools or IDEasy itself internal Nothing to be added to CHANGELOG, only internal story labels Aug 27, 2026
@JoelAdbu
JoelAdbu marked this pull request as ready for review August 27, 2026 09:51
@JoelAdbu JoelAdbu moved this from 🏗 In progress to Team Review in IDEasy board Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story linux specific for linux OS (debian, ubunutu, suse, etc.) uninstall uninstall tools or IDEasy itself

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

3 participants