Skip to content

⚡ Fix blocking File I/O and FTP Call in Async Function #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devdudumuniz wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Draft

⚡ Fix blocking File I/O and FTP Call in Async Function #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions pysus/api/ftp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,15 @@ async def download(
) -> pathlib.Path:
"""Download a remote file locally, optionally reporting progress."""

async def _fetch():
try:
self.ftp.voidcmd("NOOP")
except BrokenPipeError:
await self.connect()
def _noop():
self.ftp.voidcmd("NOOP")

try:
await to_thread.run_sync(_noop)
except BrokenPipeError:
await self.connect()

def _fetch():
total_size = self.ftp.size(str(file.path)) or 0
current_size = 0

Expand All @@ -203,7 +206,7 @@ def _write_and_callback(chunk):
self.ftp.retrbinary(f"RETR {file.path}", _write_and_callback)
return output

return await _fetch()
return await to_thread.run_sync(_fetch)

@staticmethod
def _line_parser(
Expand Down