Repository navigation
Open the payment mode popup when settling an order - #10
Merged
Merged
Conversation
Valider le paiement was a dead action. The popup was built and mounted, and the confirmPaiement handler was correct, but nothing ever called setPayingAchat — so the stale confirm() from before the payment-mode work still fired, and the validatePaiement() call had already been removed from the try block. Clicking through it showed "La caisse du chantier … sera débitée de …", then did nothing: no request, no state change, order left unpaid. The button now opens the mode popup, and the request goes out once a mode is chosen. This slipped through because every check on the payment-mode work hit the API directly. Those passed, and the endpoint really is correct — but none of them went through the button, so a UI path that never reached the API looked identical to one that did. Found by clicking it in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@khafifithebork is attempting to deploy a commit to the Mohamed najib's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valider le paiement was a dead action. The popup was built and mounted, and the confirmPaiement handler was correct, but nothing ever called setPayingAchat — so the stale confirm() from before the payment-mode work still fired, and the validatePaiement() call had already been removed from the try block. Clicking through it showed "La caisse du chantier … sera débitée de …", then did nothing: no request, no state change, order left unpaid.
The button now opens the mode popup, and the request goes out once a mode is chosen.
This slipped through because every check on the payment-mode work hit the API directly. Those passed, and the endpoint really is correct — but none of them went through the button, so a UI path that never reached the API looked identical to one that did. Found by clicking it in a browser.