Repository navigation
fix(utils): normalize IPv4 representations before integer conversion - #11954
Open
embrace897 wants to merge 1 commit into
Open
embrace897 wants to merge 1 commit into
embrace897 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IpToUint32 currently returns zero for the 16-byte IPv4 representation returned by net.ParseIP. Normalize with To4 before converting, while preserving zero for invalid inputs and native IPv6.
Validation: the isolated production-function harness fails on the original implementation and passes after the patch. Tests cover three IPv4 representations, nil, native IPv6 and malformed input. Full utils package validation is blocked by missing local dependencies; server and eBPF validation were not run. Production reachability has not been established.
Prepared with AI assistance.