Add Sharecoin (SHC) asset - #3623
Open
Share-coin wants to merge 1 commit into
Open
Conversation
Sharecoin is an untouched Bitcoin Core fork (only the PoW algorithm is changed, SHA-256d -> KawPow) - integrated as a standard BTC-clone via the existing btc.BTCCloneWallet/btc.NewBTCClone framework, following DigiByte as the closest existing reference implementation. Chain params (dex/networks/shc/params.go) read directly from this projects own chainparams.cpp, genesis hash and node version verified against a live mainnet node. Includes the dex/bip-id.go symbol entry required for markets.json to recognize the shc ticker. BipID (8443000) is self-assigned, not an official SLIP-44 index - Sharecoin has none registered, following the same convention already used by other self-registered entries in that table (aqua, kusd, fluid, qkc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SHC (Sharecoin) as a standard BTC-clone asset. Sharecoin is an untouched Bitcoin Core fork - only the PoW algorithm is changed (SHA-256d -> KawPow, vendored from Ravencoin's real integration). The rest of the RPC/wallet/script surface is upstream Bitcoin Core, so this integrates via the existing
btc.BTCCloneWallet/btc.NewBTCCloneframework, following DigiByte'sdgb.goas the closest existing reference (also a recent, untouched Bitcoin Core fork).dex/networks/shc/params.go- mainnet chain params, read directly from Sharecoin's ownchainparams.cpp, genesis hash and minimum node version cross-checked against a live mainnet node.client/asset/shc/shc.go- wallet driver (externalsharecoindRPC connection).server/asset/shc/shc.go- market-backend driver.dex/bip-id.go- adds theshcsymbol entry needed formarkets.jsonto recognize the ticker.BipID(8443000) is self-assigned, not an official SLIP-44 index - Sharecoin doesn't have one registered (confirmed against both this repo's ownbip-id.goand the upstreamsatoshilabs/slipsregistry directly). Follows the same convention already used by other self-registered entries in this same table (aqua,kusd,fluid,qkc).Mainnet-only for this PR.
Test plan
go vetandgo buildclean on all three new/modified packagesgofmt -lclean