Add example partial filter#625
Draft
ElliottKasoar wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
This shows an example implementation of partial filtering. In order to avoid redefining analysis logic, ideally we import and call functions from analysis during the app partial filter.
This means we need to make some changes to make this function callable (not a fixture, remove data-dependent module constants), and we then need to pass it suitable data, which we can get from the scatter plot in this case.
The changes are otherwise relatively intuitive, and is implemented similarly to initial work in #512.
The other question (which is why this is in draft) is whether it makes sense to merge these one at a time, or if we ought to have them all complete before activating this.
Linked issue
Partially addresses #623.