Conversation
…w-transition-group, view-transition-scope and window-drag
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
* atom-slot-keys: State design reasons in slot-key and class-format comments and remove the scratch measure tool Rename class prefixes to a-, in-, id- and k-, and key !important by context so CSS.merge needs no importance check Prefix interpolation bundles with csv- and reject atom class collisions in generate # Conflicts: # CHANGES.md
* atom-slot-keys: Encode context, family and longhand mask in atom class names and resolve CSS.merge conflicts by them Group declarations whose longhands overlap into one atom, in author order # Conflicts: # CHANGES.md
* atom-slot-keys: Bundle only interpolated declarations that share a variable, so the others merge as keyed atoms Rename class prefixes to _a_, _in_, _id_ and _k_ so hand-written a- classes are never read as atoms Emit cascade tiers so conditional rules beat base rules, own rules beat descendant defaults and globals, across stylesheets Give a lone interpolated declaration a keyed atom class so CSS.merge resolves it Hash atoms from their resolved selector so $(binding) references in different modules mint different classes Show every CSS.merge combination in the melange demo # Conflicts: # CHANGES.md
* atom-slot-keys: Keep parent-to-child rules in their context tier and sort each tier by descendant shape, then shorthand depth Describe the final class-name prefixes in the 0.62.0 changelog
* atom-slot-keys: Resolve property aliases before computing an atom's longhand mask
* atom-slot-keys: Keep a seeded property's family ID when a new shorthand joins its family, and bring the docs up to the current class names Let an explicit --dev win over --minify and --env production in any order Document how CSS.merge decides, with its examples and known limits Emit generated CSS without cascade layers, so specificity and order decide as in plain CSS Salt atom, bundle and identity classes with --namespace, defaulting to the dune library name Emit all atoms in one styled-ppx.atoms layer, base then conditional, so specificity decides before position # Conflicts: # CHANGES.md
…pe from producing invalid CSS
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers seven CSS properties that the W3C property list has, css-grammar did not know, and at least one shipping browser implements (per MDN browser-compat-data). Writing them in
[%css]was an unknown-property error before.border-shapenone | [ <basic-shape> <geometry-box>? ]{1,2}flow-tolerancenormal | <length-percentage> | infiniteframe-sizingauto | content-width | content-height | content-block-size | content-inline-sizescroll-axis-lockauto | noneview-transition-groupnormal | contain | nearest | <custom-ident>view-transition-scopenone | allwindow-dragnone | moveEach property has a runtime type, valid and invalid css-grammar cases, and a css-support cram test (
border-shape.t,flow-tolerance.t,frame-sizing.t,scroll-axis-lock.t,view-transition-group-scope.t,window-drag.t). Each also gets a newSlot_key.seedID, appended at the end.Out of scope here: the 37 CSS Gaps Module properties (
row-rule,column-rule,ruleand their families), which need new list value types, and 140 properties that are standards-track but not implemented or only in preview builds. Both follow in separate PRs.Checks at 73edc2b:
make build,make format-check,make testandDUNE_PROFILE=release make testpass.Stacked on #619.
Risk: two-way door. A revert makes the seven properties unknown again.